Package: usbguard
Version: 0.6.2+ds1-1
Severity: normal

Hi,

after installing the package, usbguard.service fails to start:

  systemd[1]: Started USBGuard daemon.
  usbguard-daemon[30357]: [1485021770.799] (E) ERROR: Configuration: /etc/usbguard/rules.conf: usbguard::Exception
  systemd[1]: usbguard.service: Main process exited, code=exited, status=1/FAILURE
  systemd[1]: usbguard.service: Unit entered failed state.
  systemd[1]: usbguard.service: Failed with result 'exit-code'.

It looks like the default config depends on a file that doesn't exist
(yet). Any reason why we should not create an empty rules.conf in
postinst if there's none (and remove it on purge)?

Cheers,

control: tags -1 + pending

Hi intrigeri,

thanks a lot for spotting this. You're totally right, there should be at
least an empty rules.conf file. I'll fix that.

cheers,
muri

control: tags -1 + moreinfo unreproducible

hi again,

i'm actually not able to reproduce the bug. if i install usbguard on a
clean stretch installation i can start usbguard[0] without having an
/etc/usbguard/rules.conf file:

was there maybe a file without read permissions? or with maybe with
rules that made usbguard choke?

(nontheless i'll still add the rules.conf in the postinst script)

cheers,
muri

[0] i found another bug, that i'll file right away

Hi,

Muri Nicanor:
installation is weird: usbguard.service is started no less than
3 times, and only the third attempt works. It looks somewhat related
to usbguard-dbus.service:

Feb 07 11:38:41 sid-desktop systemd[1]: Started USBGuard daemon.
Feb 07 11:38:41 sid-desktop systemd[1]: Starting USBGuard D-Bus Service...
Feb 07 11:38:41 sid-desktop usbguard-daemon[3693]: [1486463921.919] (E) ERROR: Configuration: /etc/usbguard/rules.conf: usbguard::Exception
Feb 07 11:38:41 sid-desktop systemd[1]: usbguard.service: Main process exited, code=exited, status=1/FAILURE
Feb 07 11:38:41 sid-desktop systemd[1]: usbguard.service: Unit entered failed state.
Feb 07 11:38:41 sid-desktop systemd[1]: usbguard.service: Failed with result 'exit-code'.
Feb 07 11:38:41 sid-desktop systemd[1]: Started USBGuard D-Bus Service.
Feb 07 11:38:42 sid-desktop systemd[1]: usbguard.service: Service hold-off time over, scheduling restart.
Feb 07 11:38:42 sid-desktop systemd[1]: Stopped USBGuard daemon.
Feb 07 11:38:42 sid-desktop systemd[1]: Started USBGuard daemon.
Feb 07 11:38:42 sid-desktop systemd[1]: Stopping USBGuard D-Bus Service...
Feb 07 11:38:42 sid-desktop systemd[1]: Stopped USBGuard D-Bus Service.
Feb 07 11:38:42 sid-desktop systemd[1]: Starting USBGuard D-Bus Service...
Feb 07 11:38:42 sid-desktop usbguard-daemon[3704]: [1486463922.084] (E) ERROR: Configuration: /etc/usbguard/rules.conf: usbguard::Exception
Feb 07 11:38:42 sid-desktop systemd[1]: usbguard.service: Main process exited, code=exited, status=1/FAILURE
Feb 07 11:38:42 sid-desktop systemd[1]: usbguard.service: Unit entered failed state.
Feb 07 11:38:42 sid-desktop systemd[1]: usbguard.service: Failed with result 'exit-code'.
Feb 07 11:38:42 sid-desktop systemd[1]: Started USBGuard D-Bus Service.
Feb 07 11:38:42 sid-desktop systemd[1]: usbguard.service: Service hold-off time over, scheduling restart.
Feb 07 11:38:42 sid-desktop systemd[1]: Stopping USBGuard D-Bus Service...
Feb 07 11:38:42 sid-desktop systemd[1]: Stopped USBGuard daemon.
Feb 07 11:38:42 sid-desktop systemd[1]: Started USBGuard daemon.
Feb 07 11:38:42 sid-desktop systemd[1]: Stopped USBGuard D-Bus Service.
Feb 07 11:38:42 sid-desktop systemd[1]: Starting USBGuard D-Bus Service...
Feb 07 11:38:42 sid-desktop systemd[1]: Started USBGuard D-Bus Service.

So in the end the service is started successfully, but still I wonder
if this strange behavior is highlighting something wrong somewhere
deeper, that could bite us in the future.

Retitling accordingly. Feel free to downgrade severity.

Sounds good!

Cheers,

Hello,

Thanks for your work on this package! This bug has the 'pending' tag
since January 24, 2017. Maybe the fix is not pending anymore?

Thanks & regards

control: tags -1 - pending

Hi,

Thanks for noticing! Yes, the fix about the missing rules.conf is not
pending anymore.

cheers,
Birger

close 852108 1.1.4+ds-7
thanks

Hi intrigeri,

thank you for your report. I've checked it with the current version from
sid, and I can't reproduce it - as far as I can see, usbguard is only
started once.

If contrary to that, you can reproduce it, please feel free to reopen
the bug.

Regards,
Daniel

close 852108 1.1.4+ds-7
thanks

Hi intrigeri,

thank you for your report. I've checked it with the current version from
sid, and I can't reproduce it - as far as I can see, usbguard is only
started once.

If contrary to that, you can reproduce it, please feel free to reopen
the bug.

Regards,
Daniel