package: needrestart
version: 2.11-2
severity: important
tag: patch

Hi,

Testing dpkg testsuite without beeing root needrestart crash.

I believe need restart need to take in account $DPKG_ROOT

at least it should not execute if dpkg-root is set (so patch)

To test install needrestart and execute as not root dpkg

Bastien

Control: tags -1 - patch + moreinfo

Using severity important for anything DPKG_ROOT related sounds dubious
to me, because the feature is not finalized in dpkg, but a technology
preview.

Please add the patch tag again once attaching the patch.

Maybe you can give more details here as to what crashes and how it
fails?

You mentioned on irc that the file you want to touch is
/etc/dpkg/dpkg.cfg.d/needrestart. That's not a maintainer script.
DPKG_ROOT is only defined during maintainer script execution. Thus
DPKG_ROOT will be undefined here.

Why should execution of needrestart depend on the way maintainer scripts
are executed? That doesn't make any sense to me. Shouldn't the real
condition be something like skipping needrestart when it is not
installed in the system /?

Helmut

No rootless dpkg fail if needrestart is installed. This is the bug.

To test install dpkg testsuite and run

 DPKG_TESTSUITE_OPTIONS="not-root" eatmydata make test

it will fail with a permission problem

tags 857730 upstream
severity 857730 wishlist
thanks


Hi Bastien,


Bastien ROUCARIES <roucaries.bastien@gmail.com> writes:

Please do not abuse the bug severity - I do not think that this issue has any
major effect on the usability of a package.

[1] https://www.debian.org/Bugs/Developer#severities

Please provide a consistent error description (Does needrestart crash or
is there a permission problem?) including some screen logs and howto
reproduce the problem.

If the testsuite stuff is WIP we maybe should wait until it is finalized
and there is a recommendation available howto handle the testsuite in
(pre-invoke|post-invoke|status-logger) commands.


HTH,
Thomas

Seems reasonable but it still fail with permission problem. It is
reproductible do not remember the exact error but it fail apt