#861168 [debsources] msg parameter displays extra line numbers when Javascript is disabled

Package:
qa.debian.org
Source:
qa.debian.org
Submitter:
Paul Wise
Date:
2021-09-22 04:36:16 UTC
Severity:
minor
Tags:
#861168#5
Date:
2017-04-25 09:57:48 UTC
From:
To:
Normally the cowsay code header looks like this:

https://sources.debian.net/src/cowsay/3.03%2Bdfsg2-3/cowsay

1   #!/usr/bin/perl
2
3   ##
4   ## Cowsay 3.03
5   ##
6   ## This file is part of cowsay.  (c) 1999-2000 Tony Monroe.
7   ##

When I add a msg parameter it looks like this:

1   #!/usr/bin/perl
2   
3   ##
4   ## Cowsay 3.03
5   
6   title
7   text
8   
9   ##
10  ## This file is part of cowsay.  (c) 1999-2000 Tony Monroe.
11  ##

I didn't expect that the msg paramer would insert line numbers,
I would expect these line numbers instead:

1   #!/usr/bin/perl
2   
3   ##
4   ## Cowsay 3.03
    
    title
    text
    
5   ##
6   ## This file is part of cowsay.  (c) 1999-2000 Tony Monroe.
7   ##
#861168#10
Date:
2017-04-25 17:49:13 UTC
From:
To:
Control: retitle -1 [debsources] msg parameter displays extra line numbers when Javascript is disabled
Control: tag -1 confirmed

Like this:

https://sources.debian.net/src/cowsay/3.03%2Bdfsg2-3/cowsay/?msg=4:title:message

When I view that URL, it looks as per your expectations.  After
disabling Javascript, I see that the line numbers aren't adjusted.

Cheers,
James
#861168#19
Date:
2017-04-25 19:58:50 UTC
From:
To:
Hi,

Thanks for the report and the additional information!

I've dug it a bit, and it indeed comes from the fact the additional
space needed between line numbers to align well (when a popup message
is present) is done in javascript in debsources.js.

A solution could be adding these empty lines server-side. It was the
case before e246fcf, but it was needed to fix #762941…

Cheers,
--
Matthieu
#861168#24
Date:
2021-09-22 04:22:10 UTC
From:
To:
Hello,

Good morning,

We have gone through your samples from a partner and Here is our  Order
List. Please do bear in mind that we are very much in  need of this
order, quote your competitive prices.

Kindly send the Order confirmation.

Your early reply will be much appreciated.

Best Regards,

Maryanah Erwin.

PT FINDORA INTERNUSA

Jln Pahlawan 66 Kec. Arjawinangun

45162 CIREBON West-Java INDONESIA

tel : +62 231 357334

fax: +62 231 357260

email: marketing@findora.com
#861168#29
Date:
2021-09-22 04:22:10 UTC
From:
To:
Hello,

Good morning,

We have gone through your samples from a partner and Here is our  Order
List. Please do bear in mind that we are very much in  need of this
order, quote your competitive prices.

Kindly send the Order confirmation.

Your early reply will be much appreciated.

Best Regards,

Maryanah Erwin.

PT FINDORA INTERNUSA

Jln Pahlawan 66 Kec. Arjawinangun

45162 CIREBON West-Java INDONESIA

tel : +62 231 357334

fax: +62 231 357260

email: marketing@findora.com