#868871 git: please restore the /usr/share/doc/contrib/diff-highlight/diff-highlight binary

Package:
git
Source:
git
Description:
fast, scalable, distributed revision control system
Submitter:
Mattia Rizzolo
Date:
2023-05-14 01:30:04 UTC
Severity:
wishlist
Tags:
#868871#3
Date:
2017-07-19 11:09:54 UTC
From:
To:
While waiting for #827292 the situation IMHO actually regressed as the
file is not there anymore.
Apparently users are now expected to run `make` in
/usr/share/doc/git/contrib/diff-highlight to obtain the binary again.

Please run make as part of the package build and restore the file
#868871#8
Date:
2017-09-28 19:37:38 UTC
From:
To:
tags 868871 patch
thanks

I have the same request -- I had been using:

That way my diff-highlight script was always up to date.

I just APT-updated and it stopped working (since diff-highlight must now
be built, as of this commit [1]).

I think the following will resolve this, by running the diff-highlight
Makefile when the package is built (following the pattern in
debian/rules for other contrib things):

[1]
https://github.com/git/git/commit/0c977dbc8180892af42d7ab9235fd3e51d6c4078
#868871#25
Date:
2020-11-17 16:46:35 UTC
From:
To:
Any reason why this hasn't been applied to the package just yet?

I'd be happy to do that in a NMU if there are no objections...

a.
#868871#30
Date:
2020-11-17 23:17:44 UTC
From:
To:
Antoine Beaupré wrote:

Please don't.  Adding additional contrib/ code to the supported
surface without coordination is not an NMU I'd welcome at all
(instead, it would be a bit of a rude shock).

Would it make sense to install this to /usr/share/git-core/contrib/?

If not, could it go in a separate package (within the same source
package)?

I'm also curious about how this compares to
https://pypi.org/project/diff-highlight/

Thanks,
Jonathan
#868871#35
Date:
2020-11-18 15:07:43 UTC
From:
To:
Happy to discuss it further. ;) It's why I wrote this, after all.. I
wouldn't NMU without first asking, obviously.

Sure, that's a good start.

That could be nice as well.

Either way, having some way for users to enable it would be nice. From
what I understand, it actually used to ship in the package and that
changed with upstream changes so it would be nice to restore that...

No idea.

a.
#868871#46
Date:
2023-01-15 03:41:46 UTC
From:
To:
Both choises sound good to me.

Lack of diff-highlight currently blocks https://bugs.debian.org/931427. I don’t
think the Python version can work as a replacement in this case, so please
package the Git version regardless.
#868871#51
Date:
2023-05-12 14:43:34 UTC
From:
To:
Good morning,

 Attached please find your PDF account statement and invoice as of 05/11/2023. Please notice you have a past due balance  for invoice IN0099203.

 Please provide payment as soon as possible.




 Best Regards,
 Shawneen Chisholm
 Accounts Receivable Coordinator

 UNITED RENTALS, INC.
Branch L02 BONNYVILLE
4920 56TH AVE
BONNYVILLE AB T9N 2N8 CA
780-826-7610


 CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s). This may contain confidential and/or privileged information and may be legally protected from disclosure. If you are not the intended recipient of this message, please alert the sender immediately by reply email and then delete this message and any attachments. Any disclosure, reproduction, distribution or other use of this message or any attachments by an individual or entity other than the intended recipient is prohibited