The machine configuration for "HP t5325 Thin Client" defined in /usr/share/flash-kernel/db/all.db has Bootloader-Sets-Incorrect-Root field set to 'yes'. It is best if that field (Bootloader-Sets-Incorrect-Root) is not set for HP t5325 Thin Client.

The U-BOOT environment of the device supports passing boot arguments which can be used to specify the device holding the rootfs. Having the said field set to 'yes' hides the capability of the device - so that the convenience of changing the boot argument via U-BOOT environment to specify a different rootfs is lost.

I have verified that the corresponding setting can be negated via the /etc/flash-kernel/db file by having the following two lines:

Machine: HP t5325 Thin Client
Bootloader-Sets-Incorrect-Root: no

However, it would be much better to have the defaults as defined in the database included in the flash-kernel package reflect the capability of the device.

Kamal

Hello Martin,

as you have been the original contributor of the support for this
device in flash-kernel, I wanted to kindly ask whether you could
perhaps take a look at this and provide some insight about why the
flag was originally included.

Regards,
Karsten

* Karsten Merker <merker@debian.org> [2017-10-11 20:26]:

Well, the HP t5325 u-boot configuration sets root=/dev/sda1, which we
cannot rely on.  Historically, flash-kernel sets
Bootloader-Sets-Incorrect-Root if the default config sets a root=
parameter.

Maybe the HP t5325 situation is different because the default config
doesn't work anyway with Debian and you have to modify it, so you may
just as well modify root= too.

In any case, this device was never supported by HP t5325 anyway so I
don't mind either way.