#881281 ugly scaled icons in the toolar

Package:
wxmaxima
Source:
wxmaxima
Description:
GUI for the computer algebra system Maxima
Submitter:
Stanislav Maslovski
Date:
2017-11-10 16:00:05 UTC
Severity:
minor
#881281#5
Date:
2017-11-09 15:42:52 UTC
From:
To:
Hi,

This version of wxmaxima, as compared to 16.04.2, applies unnecessary scaling to the toolbar
icons. The result of this scaling is very aestetically unpleasing to the point of being disturbing.

If you look into the source code of ToolBar.c of ver. WxMaxima 16.04.2 you will find that the
scaling is only applied when running on Windows or Mac, and disabled elsewhere.
So I did the same change to ver. 17.10.1, which you will find in the attached patch.

I have checked that with this patch the toolbar icons look much better in all resolutions
available on my display, which are

   1920x1080     60.00*+
   1680x1050     59.95
   1600x900      60.00
   1440x900      59.89
   1280x1024     75.02    60.02
   1280x800      59.81
   1280x720      60.00
   1152x864      75.00
   1024x768      75.03    70.07    60.00
   800x600       75.00    72.19    60.32    56.25
   640x480       75.00    72.81    59.94

#881281#10
Date:
2017-11-10 05:37:24 UTC
From:
To:
I had added the scaling because normally gtk+ automatically delivers me the icons in the Right  size. But
 - on some icon themes a few icons were grossly of the wrong size. For example in my favourite theme I got a 512x512 pixel-sun on a 96dpi display.
 - and on debian a few themes lack some standard icons so wxMaxima falls back to the icons it comes with - that are big so scaling them down still doesn't produce icons that are too blurry.

 If you
 - extend the patch to just scale the icons if they are obviously way too big
 - and if you limit the scaling to 1/n and 1.5/n with n being an integer (this will reduce the blur to a minimum in the cases scaling is necessary)
I'll apply it and upstream it so the next official release no more scales icons on wxGTK.

Thanks a lot,
and kind regards,

     Gunter.

#881281#15
Date:
2017-11-10 05:37:24 UTC
From:
To:
I had added the scaling because normally gtk+ automatically delivers me the icons in the Right  size. But
 - on some icon themes a few icons were grossly of the wrong size. For example in my favourite theme I got a 512x512 pixel-sun on a 96dpi display.
 - and on debian a few themes lack some standard icons so wxMaxima falls back to the icons it comes with - that are big so scaling them down still doesn't produce icons that are too blurry.

 If you
 - extend the patch to just scale the icons if they are obviously way too big
 - and if you limit the scaling to 1/n and 1.5/n with n being an integer (this will reduce the blur to a minimum in the cases scaling is necessary)
I'll apply it and upstream it so the next official release no more scales icons on wxGTK.

Thanks a lot,
and kind regards,

     Gunter.

#881281#20
Date:
2017-11-10 12:19:34 UTC
From:
To:
Hi,

I see the problem. Here on my system wxmaxima uses its own icons. They look
bad when scaled. Also, the height of the toolbar is too large.
Can you point me to the icon theme you are using, so that I could check
this issue further?

#881281#25
Date:
2017-11-10 12:19:34 UTC
From:
To:
Hi,

I see the problem. Here on my system wxmaxima uses its own icons. They look
bad when scaled. Also, the height of the toolbar is too large.
Can you point me to the icon theme you are using, so that I could check
this issue further?

#881281#30
Date:
2017-11-10 15:57:25 UTC
From:
To:
Gartoon and Gartoon Redux. The offending item there should be the sun. And you should be using the debian default theme which is lacking a few symbols. As wxMaxima and debian use tango icons it is quite hard to tell which icon comes from where, optically.

Kind regards, Gunter.

Am 10. November 2017 13:19:34 MEZ schrieb Stanislav Maslovski <stanislav.maslovski@gmail.com>:

#881281#35
Date:
2017-11-10 15:57:25 UTC
From:
To:
Gartoon and Gartoon Redux. The offending item there should be the sun. And you should be using the debian default theme which is lacking a few symbols. As wxMaxima and debian use tango icons it is quite hard to tell which icon comes from where, optically.

Kind regards, Gunter.

Am 10. November 2017 13:19:34 MEZ schrieb Stanislav Maslovski <stanislav.maslovski@gmail.com>: