#884135 UDD/upstream: should honor comment-only watch file

#884135#5
Date:
2017-12-11 19:59:55 UTC
From:
To:
Multiple of my packages do not have a proper URL to watch. Lintian suggest to
add a watch file with comments, and uscan handles those gracefully. UDD
turns them into an error on line 106 in rimporters/upstream.rb.

Please improve UDD to treat "empty" watch files as they are meant to be by
people that follow Lintian's advice.


- -- System Information:
Debian Release: buster/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (200, 'testing'), (50, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.13.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEWLZtSHNr6TsFLeZynFyZ6wW9dQoFAlou47sACgkQnFyZ6wW9
dQpmGwgAqDPl9V5CxORey5p9hXS8BJUCZ4yxHbpcH9MrGSHL/bfDc5tdIpM3SIP9
bgaimPNL/IZ3LA2UCFAlJwTWnVDUH7PzmLu3GJ9Pay5wOK5t2jvt09Pp0+kVZNh7
LwUs0Uy4rNt821917mXQaVD3P7kOiYjrNbUmWSwNzKCgx06pqD7G9IBnrN6UDI2y
hrlWiI1O2kpAf7CKZO64Yj8yNSYU2GC1TqIJpCxxhj4gcGaye5NDjTv6k7EtzW1N
k3SpjK16AMceZ+PHeVPAdhlU/qcNq4M0jSXAdyvSCiKWHtREMNhx1gSnAXqmNU0G
LNSE+g030r6aN6fgrXIUL4ssOKmkeg==
=YFZE
-----END PGP SIGNATURE-----

#884135#12
Date:
2020-06-28 19:50:58 UTC
From:
To:
Hi,

select source,watch_file,last_check,status from upstream where watch_file is not null and length(watch_file) < 30;

Lucas

#884135#17
Date:
2026-02-24 01:38:07 UTC
From:
To:
Hi!

[ CCing Lucas for UDD, and Christoph for DDPO. ]

I think using the new watch format 5 with its "Untrackable:" field
support is probably a more explicit way to handle this, which is what
I've switched the couple of packages that I maintain that are in this
same situation.

To try to improve this I tried to modify both UDD and DDPO, to track
and show these as a new status, and show on DDPO in gray to avoid
creating the current alarming red upper-case entries, which seem wrong
given that I don't think these packages should be worse-off than ones
with no watch file included.

The attached two patches try to implement this, but they are
completely untested. I guess the one in UDD could be massaged to also
include the watch format 4 with only comments (originally requested in
this report), by checking in the same if/else case that none of the
fields are present (given that the previous cases handle non-existing
watch file).

(I've also provided an MR for lintian updating its recommendation to
use format 5 with
<https://salsa.debian.org/lintian/lintian/-/merge_requests/668>)

Thanks,
Guillem

#884135#22
Date:
2026-04-25 14:35:01 UTC
From:
To:
Hi!

I've now also submitted a couple of MR with the previously attached
patches:

https://salsa.debian.org/qa/udd/-/merge_requests/68
https://salsa.debian.org/qa/qa/-/merge_requests/67

Thanks,
Guillem

#884135#27
Date:
2026-05-14 08:26:32 UTC
From:
To:
Hi,

The changes have been merged in UDD and DDPO.

I'm leaving the bug open as version 4 is not covered by the changes, but
the affected packages should really move to version 5 and use
Untrackable.

Lucas