Hi, current output: % dput ftp-eu *changes Checking signature on .changes gpg: /home/agaida/work/code/pkg-main/lxqt-qtplugin/lxqt-qtplugin_0.12.0-4_source.changes: error 58: Invocation of gpgme_op_verify Invocation of gpgme_op_verify: GPGME: No data Should be something like: "Can't upload, UNRELEASED!"
Control: tags -1 + moreinfo Can you try the command with only the one upload control file (‘foo.changes’, whatever that file is)? This will help narrow down what is causing the behaviour. Can you send that upload control file, as an attachment on a message to this bug report? The message is telling you of a failure when trying to verify the GnuPG signature. I think this is not related to the name in the distribution field. But I will need to see answers to the above questions, to diagnose further.
D: dput 1.0.1
D: Login: agaida
D: Parsing Configuration File /etc/dput.cf
No such file or directory: /home/agaida/.dput.cf, skipping
D: Checking if a host was named on the command line.
D: Host ftp-eu found in config
D: modules_found: ['ftp', 'http', 'https', 'local', 'rsync', 'scp']
D: Module: ftp (<module 'dput.methods.ftp' from
'/usr/share/dput/dput/methods/ftp.py'>)
D: Method name: ftp
D: Module: http (<module 'dput.methods.http' from
'/usr/share/dput/dput/methods/http.py'>)
D: Method name: http
D: Module: https (<module 'dput.methods.https' from
'/usr/share/dput/dput/methods/https.py'>)
D: Method name: https
D: Module: local (<module 'dput.methods.local' from
'/usr/share/dput/dput/methods/local.py'>)
D: Method name: local
D: Module: rsync (<module 'dput.methods.rsync' from
'/usr/share/dput/dput/methods/rsync.py'>)
D: Method name: rsync
D: Module: scp (<module 'dput.methods.scp' from
'/usr/share/dput/dput/methods/scp.py'>)
D: Method name: scp
D: Validating contents of changes file
/home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.changes
D: Architecture: source
D: dsc-File: qps_1.10.17-2.dsc
D: upload control file:
/home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.changes
D: source control file:
/home/agaida/work/code/pkg-main/qps/qps_1.10.17-2.dsc
Checking signature on .changes
gpg: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.changes:
error 58: gpgme_op_verify
gpgme_op_verify: GPGME: No data
% dput -d ftp-eu qps_1.10.17-2_source.changes
:(
D: dput 1.0.1
D: Login: agaida
D: Parsing Configuration File /etc/dput.cf
No such file or directory: /home/agaida/.dput.cf, skipping
D: Checking if a host was named on the command line.
D: Host ftp-eu found in config
D: modules_found: ['ftp', 'http', 'https', 'local', 'rsync', 'scp']
D: Module: ftp (<module 'dput.methods.ftp' from
'/usr/share/dput/dput/methods/ftp.py'>)
D: Method name: ftp
D: Module: http (<module 'dput.methods.http' from
'/usr/share/dput/dput/methods/http.py'>)
D: Method name: http
D: Module: https (<module 'dput.methods.https' from
'/usr/share/dput/dput/methods/https.py'>)
D: Method name: https
D: Module: local (<module 'dput.methods.local' from
'/usr/share/dput/dput/methods/local.py'>)
D: Method name: local
D: Module: rsync (<module 'dput.methods.rsync' from
'/usr/share/dput/dput/methods/rsync.py'>)
D: Method name: rsync
D: Module: scp (<module 'dput.methods.scp' from
'/usr/share/dput/dput/methods/scp.py'>)
D: Method name: scp
D: Validating contents of changes file
/home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.changes
D: Architecture: source
D: dsc-File: qps_1.10.17-2.dsc
D: upload control file:
/home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.changes
D: source control file:
/home/agaida/work/code/pkg-main/qps/qps_1.10.17-2.dsc
Checking signature on .changes
gpg: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.changes:
error 58: gpgme_op_verify
gpgme_op_verify: GPGME: No data
done
i have some packages that need work so we have enough to play with
Cheers Alf
On 15.12.2017 01:26, Ben Finney wrote:> Can you try the command with only the one upload control file % dput -d ftp-eu qps_1.10.17-2_source.changes D: dput 1.0.1 D: Login: agaida D: Parsing Configuration File /etc/dput.cf No such file or directory: /home/agaida/.dput.cf, skipping D: Checking if a host was named on the command line. D: Host ftp-eu found in config D: modules_found: ['ftp', 'http', 'https', 'local', 'rsync', 'scp'] D: Module: ftp (<module 'dput.methods.ftp' from '/usr/share/dput/dput/methods/ftp.py'>) D: Method name: ftp D: Module: http (<module 'dput.methods.http' from '/usr/share/dput/dput/methods/http.py'>) D: Method name: http D: Module: https (<module 'dput.methods.https' from '/usr/share/dput/dput/methods/https.py'>) D: Method name: https D: Module: local (<module 'dput.methods.local' from '/usr/share/dput/dput/methods/local.py'>) D: Method name: local D: Module: rsync (<module 'dput.methods.rsync' from '/usr/share/dput/dput/methods/rsync.py'>) D: Method name: rsync D: Module: scp (<module 'dput.methods.scp' from '/usr/share/dput/dput/methods/scp.py'>) D: Method name: scp D: Validating contents of changes file /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.changes D: Architecture: source D: dsc-File: qps_1.10.17-2.dsc D: upload control file: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.changes D: source control file: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2.dsc Checking signature on .changes gpg: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.changes: Valid signature from CD280A0B4D72827C Checking signature on .dsc gpg: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2.dsc: Valid signature from CD280A0B4D72827C D: Package Version: 1.10.17-2 D: Upstream Version: 1.10.17 D: Debian Version: 2 D: File to upload: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2.dsc D: Checksum for /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2.dsc is fine D: File to upload: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2.debian.tar.xz D: Checksum for /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2.debian.tar.xz is fine D: File to upload: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.buildinfo D: Checksum for /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.buildinfo is fine D: Checking: distribution unstable matches (?!UNRELEASED|.*-security) D: File to upload: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.changes D: Default Method: scp D: Host Method: ftp D: Login anonymous from section ftp-eu used Uploading to ftp-eu (via ftp to ftp.eu.upload.debian.org): D: FQDN: ftp.eu.upload.debian.org D: Login: anonymous D: Incoming: /pub/UploadQueue/ D: FTP port: 21 D: Using passive ftp D: FTP-Connection to host: ftp.eu.upload.debian.org D: Directory to upload to: /pub/UploadQueue/ D: Uploading File: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2.dsc Uploading qps_1.10.17-2.dsc: done. D: Uploading File: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2.debian.tar.xz Uploading qps_1.10.17-2.debian.tar.xz: done. D: Uploading File: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.buildinfo Uploading qps_1.10.17-2_source.buildinfo: done. D: Uploading File: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.changes Uploading qps_1.10.17-2_source.changes: done. D: Writing logfile: /home/agaida/work/code/pkg-main/qps/qps_1.10.17-2_source.ftp-eu.upload Successfully uploaded packages. D: dinstall: False D: Host Config: False D: Command: dput-post-upload
Thanks. As can be seen from the file you attached to that message ‘qps_1.10.17-2_source.changes’, there is no GnuPG data. So checking the signature produces the above error. Note that the file you attached to that message is now GnuPG-signed. That is what makes the difference, and which is why the above behaviour is not seen. This is because the file ‘qps_1.10.17-2_source.changes’, as attached to that message, is GnuPG-signed. So the GnuPG signature check has data to work with, and it doesn't produce the error. So I think you've demonstrated this is not anything to do with the Distribution field.
You are right, but that's not the point - and i have no real problems with the current behaviour - it only sucked the first time i noticed that. It migth be that one get distracted within the work (cell, phone, wife, dog, whatever) - and simply forget to release/sign the files. And in that case it would be nice to have a little bit more user friendly message, so the reaction would not be "WTF?!" but "Ok, pebcak" Cheers Alf
I'm having difficulty figuring out what bug is being described here. being checked for a GnuPG signature, and has no GnuPG data. You've acknowledged that is correct behaviour. So I'm left without knowing what specific problem this bug report is for. Can you describe what the specific problem is, and say what concrete change you're proposing that would address the specific problem?
Thats easy, the test for allowed_distributions is far to late in verify_files. Trivial tests first - i must not check for content, files, signatures or anything else if i can't upload because i'm not allowed to upload for the distribution in charge. And UNRELEASED isn't allowed. Patch is attached. Sorry, that will break one of the late tests, i guess 4801 or 4802. Different issue. Cheers Alf
So now a successful upload looks like: % dput -d ftp-eu *changes D: dput 1.0.1+nmu1 D: Login: agaida D: Parsing Configuration File /etc/dput.cf No such file or directory: /home/agaida/.dput.cf, skipping D: Checking if a host was named on the command line. D: Host ftp-eu found in config D: modules_found: ['ftp', 'http', 'https', 'local', 'rsync', 'scp'] D: Module: ftp (<module 'dput.methods.ftp' from '/usr/share/dput/dput/methods/ftp.py'>) D: Method name: ftp D: Module: http (<module 'dput.methods.http' from '/usr/share/dput/dput/methods/http.py'>) D: Method name: http D: Module: https (<module 'dput.methods.https' from '/usr/share/dput/dput/methods/https.py'>) D: Method name: https D: Module: local (<module 'dput.methods.local' from '/usr/share/dput/dput/methods/local.py'>) D: Method name: local D: Module: rsync (<module 'dput.methods.rsync' from '/usr/share/dput/dput/methods/rsync.py'>) D: Method name: rsync D: Module: scp (<module 'dput.methods.scp' from '/usr/share/dput/dput/methods/scp.py'>) D: Method name: scp D: Validating contents of changes file /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2_source.changes D: Checking: distribution unstable matches (?!UNRELEASED|.*-security) D: Architecture: source D: dsc-File: xfwm4-theme-breeze_0.1.0-2.dsc D: upload control file: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2_source.changes D: source control file: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2.dsc Checking signature on .changes gpg: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2_source.changes: Valid signature from CD280A0B4D72827C Checking signature on .dsc gpg: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2.dsc: Valid signature from CD280A0B4D72827C D: Package Version: 0.1.0-2 D: Upstream Version: 0.1.0 D: Debian Version: 2 D: File to upload: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2.dsc D: Checksum for /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2.dsc is fine D: File to upload: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2.debian.tar.xz D: Checksum for /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2.debian.tar.xz is fine D: File to upload: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2_source.buildinfo D: Checksum for /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2_source.buildinfo is fine D: File to upload: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2_source.changes D: Default Method: scp D: Host Method: ftp D: Login anonymous from section ftp-eu used Uploading to ftp-eu (via ftp to ftp.eu.upload.debian.org): D: FQDN: ftp.eu.upload.debian.org D: Login: anonymous D: Incoming: /pub/UploadQueue/ D: FTP port: 21 D: Using passive ftp D: FTP-Connection to host: ftp.eu.upload.debian.org D: Directory to upload to: /pub/UploadQueue/ D: Uploading File: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2.dsc Uploading xfwm4-theme-breeze_0.1.0-2.dsc: done. D: Uploading File: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2.debian.tar.xz Uploading xfwm4-theme-breeze_0.1.0-2.debian.tar.xz: done. D: Uploading File: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2_source.buildinfo Uploading xfwm4-theme-breeze_0.1.0-2_source.buildinfo: done. D: Uploading File: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2_source.changes Uploading xfwm4-theme-breeze_0.1.0-2_source.changes: done. D: Writing logfile: /home/agaida/work/code/pkg-main/xfwm4-theme-breeze/xfwm4-theme-breeze_0.1.0-2_source.ftp-eu.upload Successfully uploaded packages. D: dinstall: False D: Host Config: False
With the patch the allowed_distributions will be tested first: Hmm - i'm not really a friend of backtraces and such things - this is a handled case and dput should terminate nicely with exactly this error message: A traceback is imho some kind of overkill. Cheers Alf
Control: tags -1 - moreinfo Control: severity -1 wishlist Control: retitle -1 dput: Test ‘allowed_distributions’ earlier So as best I can determine, you are asking for a design change; not reporting any faulty behaviour of the program. I'll set the severity and title of this bug report accordingly.
If you call correct behaviour a design change you are right, but thats not my problem anymore, i have an eight year tradition running self patched dput's. Cheers Alf
You have not shown any of the existing behaviour to be incorrect; you have acknowledged that it is correct. (That is unrelated to whether different proposed behaviour might *also* be correct.) Instead, what you have proposed is justified not by any incorrect behaviour of the program, but a preference between alternative designs. So this report is a request for enhancement, since we both agree the existing behaviour is correct. Thanks again for describing the details.