Dear Maintainer,

*** Reporter, please consider answering these questions, where
appropriate ***

    * What led up to the situation?
Installed Debian Buster/Sid with Cinnamon 3.6.7-8

    * What exactly did you do (or not do) that was effective
      (or ineffective)?
Switching themes.

    * What was the outcome of this action?
If you switch between different "window borders" in the theme settings,
you will find that in some themes (for example in Default, Greybird,
Menta, BlueMenta ...) in some dialog boxes the close button at the top
right of the dialog is missing!
The theme Bluebird contains the Close button.
See also the two attached screenshots to illustrate the problem.

  * What outcome did you expect instead?
The Close button should be present in all themes.


ii  cinnamon            3.6.7-8        amd64

Modal windows don't show a close button, that's just the way things are.
Modal windows should show a Close or YES/NO button at the bottom.

Also, gtk apps could use client side decorations which override the
window manager settings, so you might be seeing some windows that are
designed no to show a titlebar with buttons in it.

If you are really annoyed by this you might want to try giving
gtk3-nocsd, but personally I consider gtk3-nocsd a hack.

In any case this doesn't look like cinnamon bug but a gtk3 behavior.

Happy hacking,

Hi Peter,

sorry for the very long delay in answering.

Maximiliano's analysis back in 2018 still holds: the titlebar buttons are
drawn by the window manager, not by the cinnamon package, and GTK
applications using client side decorations draw their own headerbar,
which the window manager cannot influence.

Beyond that, the mechanism your report is about is gone. The per-theme
"window borders" were Metacity XML themes, which defined buttons per
frame type; muffin dropped that theme parser in 5.4.1, when it was
rebased on a modern mutter. Decorations are now drawn with GTK CSS from a
built-in layout in which normal, dialog and modal dialog frames share the
same buttons, and the button set comes only from the global
org.cinnamon.desktop.wm.preferences button-layout key. The "window
borders" chooser no longer exists in the theme settings either.

So a difference in the close button between one theme and another is no
longer possible, and I'm closing this bug. If you see a specific dialog
without a close button on trixie or sid, please open a new report naming
the application.

Thanks for the report,
Fabio