I recently had occasion to compare two EDID files. I initially tried
diffoscope, saw only a hexdump and then manually compared the files
using a diff of pipes through edid-decode. Subsequently I looked up how
to add new formats to diffoscope and found it was fairly easy.

If the attached patch is acceptable, let me know and I'll push the
OpenPGP-signed version of the commit.

diff -u <(edid-decode /lib/firmware/edid/VGA-1) <(edid-decode /sys/devices/pci0000:00/0000:00:03.0/0000:01:00.0/drm/card0/card0-DVI-D-1/edid )

https://en.wikipedia.org/wiki/Extended_Display_Identification_Data

:)
 * add a test
 * expand that TODO item, I can't understand what it is about
 * wrap the long lines the way pep8 teaches
 * explain why the external_tools.py's dict lists both edid-decode and
   read-edid, but in the build-dep are made as alternatives

Mattia Rizzolo wrote:

Gentle ping on these, pabs? :)


Best wishes,

EDID data is almost always proprietary so I'm not sure how to do that.

diffoscope does not compare the output of the commands when one of them
returns an exit code other than zero. As far as I can tell this is
hard-coded in the File class, so I assumed this was a design choice?

$ git grep -p -B9 -A1 'exited with'

Both are optional and only run if installed, either one is useful for
comparing the files but edid-decode shows more details.

Hi Paul,

Something that at least has the first 'n' bytes or so so we can
check that the "recognition" for this file type works would be
the minimum here I think.

I believe Mattia was asking for this to be explained in the code
itself - having info solely in the BTS will mean that it will quickly
become arduous and time-consuming to find, let alone organically
discover.

However, I do not think diffoscope should have a global "check,
regardless of UNIX return code of external tool" -- that should be
up to each comparator to determine and feels very niche at this
point. Thus, dropping the TODO line migh tbe best course of action
here.

(Again, I believe the request was asking for this to be explained in
the code itself.)


Looking forward to receiving your updated patch. :)


Regards,

Chris Lamb wrote:

Gentle ping on this? :)


Best wishes,

Hi Paul,

Just wondering if you've had any further input on this? :)


Best wishes,

Chris Lamb wrote:

Paul, just wondering what your latest thoughts on this bug were? :) Is
this something you think you can drive or should someone take over..?


Best wishes,

If someone wants to take over, please feel free.
Otherwise I'll get to it at some point.

tags 896934 - patch
thanks

Sure thing. Tagging as -patch for clarity in the BTS for now... :)


Regards,

forwarded 896934 https://salsa.debian.org/reproducible-builds/diffoscope/issues/31
thanks

I've forwarded this upstream here:

https://salsa.debian.org/reproducible-builds/diffoscope/issues/31


Regards,

Hello,

Good morning,

We have gone through your samples from a partner and Here is our  Order
List. Please do bear in mind that we are very much in  need of this
order, quote your competitive prices.

Kindly send the Order confirmation.

Your early reply will be much appreciated.

Best Regards,

Maryanah Erwin.

PT FINDORA INTERNUSA

Jln Pahlawan 66 Kec. Arjawinangun

45162 CIREBON West-Java INDONESIA

tel : +62 231 357334

fax: +62 231 357260

email: marketing@findora.com