#909766 Use Debian packaged spdlog instead of code copy of old version

#909766#5
Date:
2018-09-27 20:38:55 UTC
From:
To:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/rapmap.html

...
In file included from /build/1st/rapmap-0.5.0+dfsg/src/RapMapUtils.cpp:26:
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp: In function 'void rapmap::utils::writeSAMHeader(IndexT&, std::shared_ptr<spdlog::logger>)':
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:86:18: error: 'MemoryWriter' is not a member of 'fmt'
             fmt::MemoryWriter hd;
                  ^~~~~~~~~~~~
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:87:6: error: 'hd' was not declared in this scope
      hd.write("@HD\tVN:1.0\tSO:unknown\n");
      ^~
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp: In function 'void rapmap::utils::writeSAMHeader(IndexT&, std::ostream&)':
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:106:18: error: 'MemoryWriter' is not a member of 'fmt'
             fmt::MemoryWriter hd;
                  ^~~~~~~~~~~~
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:107:6: error: 'hd' was not declared in this scope
      hd.write("@HD\tVN:1.0\tSO:unknown\n");
      ^~
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp: At global scope:
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:125:43: error: expected template-name before '<' token
     class FixedBuffer : public fmt::Buffer<char> {
                                           ^
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:125:43: error: expected '{' before '<' token
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:125:43: error: expected unqualified-id before '<' token
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:136:44: error: expected class-name before '{' token
     class FixedWriter : public fmt::Writer {
                                            ^
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:138:25: error: field 'buffer_' has incomplete type 'rapmap::utils::FixedBuffer'
             FixedBuffer buffer_;
                         ^~~~~~~
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:125:11: note: forward declaration of 'class rapmap::utils::FixedBuffer'
     class FixedBuffer : public fmt::Buffer<char> {
           ^~~~~~~~~~~
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp: In constructor 'rapmap::utils::FixedWriter::FixedWriter(char*, std::size_t)':
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:141:30: error: expected class-name before '(' token
                 : fmt::Writer(buffer_), buffer_(array, size) {}
                              ^
/build/1st/rapmap-0.5.0+dfsg/include/RapMapUtils.hpp:141:30: error: expected '{' before '(' token
...

#909766#10
Date:
2018-09-28 09:20:18 UTC
From:
To:
Control: tags -1 help

I admit my limited knowledge in C++ does not enable me to see a
conncetion between the update of spdlog and these errors but a test
build with libspdlog from testing passed flawlessly.  However, later in
the log there are also

...
In file included from /usr/include/c++/8/memory:81,
                 from /usr/include/c++/8/thread:39,
                 from /build/rapmap-0.5.0+x/src/RapMapSAMapper.cpp:33:
/usr/include/c++/8/bits/shared_ptr.h:719:5: note: candidate: 'template<class _Tp, class ... _Args> std::shared_ptr<_Tp> std::make_shared(_Args&& ...)'
     make_shared(_Args&&... __args)
     ^~~~~~~~~~~
/usr/include/c++/8/bits/shared_ptr.h:719:5: note:   template argument deduction/substitution failed:
/build/rapmap-0.5.0+x/src/RapMapSAMapper.cpp:588:80: error: template argument 1 is invalid
   auto consoleSink = std::make_shared<spdlog::sinks::ansicolor_stderr_sink_mt>();
                                                                                ^
/build/rapmap-0.5.0+x/src/RapMapSAMapper.cpp:589:62: error: no matching function for call to 'create(const char [10], <brace-enclosed initializer list>)'
   auto consoleLog = spdlog::create("stderrLog", {consoleSink});
                                                              ^


which are looking similar to the problem in #909763 (thus I again took
the freedom to set Gert in CC).

I see another option to work around the current issue since rapmap comes
with its own copy of spdlog (in latest Git version 0.16.3).  I could
revert the exclusion from the rapmap source code as long as upstream has
not yet switched to spdlog 1.1. (and ask in an issue for the migration).

Kind regards

      Andreas.

#909766#17
Date:
2018-12-13 10:00:11 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
rapmap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 909766@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Tille <tille@debian.org> (supplier of updated rapmap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Wed, 12 Dec 2018 23:05:04 +0100
Source: rapmap
Binary: rapmap rapmap-example-data rapmap-dev
Architecture: source amd64 all
Version: 0.12.0+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>
Changed-By: Andreas Tille <tille@debian.org>
Description:
 rapmap     - rapid sensitive and accurate DNA read mapping via quasi-mapping
 rapmap-dev - rapmap - rapid sensitive and accurate DNA read mapping (some head
 rapmap-example-data - example data for rapmap - rapid sensitive and accurate DNA read m
Closes: 909766
Changes:
 rapmap (0.12.0+dfsg-1) unstable; urgency=medium
 .
   * New upstream version
   * Point Vcs fields to salsa.debian.org
   * Standards-Version: 4.2.1
   * Remove trailing whitespace in debian/rules
   * For some reason rapmap releases are prefixed by "salmon-" - adapt
     watch file
   * Do not exclude spdlog any more as long as it is not ported to
     version spdlog 1.2.x
     Closes: #909766
   * Add rapmap-dev package to simplify building salmon and avoid code
     duplication in salmon package source
   * Lintian override for script-with-language-extension
   * Avoid privacy breach
Checksums-Sha1:
 277e2f5f47b42ca699755dbee663ccb8d8edb44b 2275 rapmap_0.12.0+dfsg-1.dsc
 735d1e35ddc61f82a27e2ecea6bdc0f06c087607 547544 rapmap_0.12.0+dfsg.orig.tar.xz
 1556285e76f0c3085dbf976a013ad0c15bbe8ca5 9692 rapmap_0.12.0+dfsg-1.debian.tar.xz
 952d63f391cdc29e9bfeb32a4977c138fcdf954f 7533028 rapmap-dbgsym_0.12.0+dfsg-1_amd64.deb
 32e3f9a4bf0bc11efdfc53e299fc7a5922b87703 98384 rapmap-dev_0.12.0+dfsg-1_all.deb
 6c071a957c732403c63b8fe9ae21958c215b696f 411640 rapmap-example-data_0.12.0+dfsg-1_all.deb
 94e08137ae9942a954608b3fd71a6c655a3a3f87 8039 rapmap_0.12.0+dfsg-1_amd64.buildinfo
 26b71987d10ea0f3523cabfd0dd99556cc5e2d13 732928 rapmap_0.12.0+dfsg-1_amd64.deb
Checksums-Sha256:
 eed5fe87a8d2df3b5deedfc181c78f2485a75d8582e9a8a5b5c52b57b855429c 2275 rapmap_0.12.0+dfsg-1.dsc
 13a03f40f7a43f89a5f274c13178985285017a0e8ccc2df6e22674ae3769b447 547544 rapmap_0.12.0+dfsg.orig.tar.xz
 e8d777838a93b349e34d5b6bdb39feb3ea73b3533c72e327b32544e3152a09b5 9692 rapmap_0.12.0+dfsg-1.debian.tar.xz
 f553fe52e63e89628741c7a06023d5945f98f75417e432943fa549d7e7ead8a9 7533028 rapmap-dbgsym_0.12.0+dfsg-1_amd64.deb
 051e6dc79353c78ece2e45e80d8d793afd78a4bd71c440858f938b22b0b298a6 98384 rapmap-dev_0.12.0+dfsg-1_all.deb
 2f17c24370880007924a008c8fda188b58aaed85fc1982e1aec5267cfa7fc88c 411640 rapmap-example-data_0.12.0+dfsg-1_all.deb
 127b1fb9e4fb32b9d5da14a874ad587bbf727bd4b8418f4570b88d7de86f3b81 8039 rapmap_0.12.0+dfsg-1_amd64.buildinfo
 f09fde553f9f254134f72ff58ab888ed3b05c2816555e552b0f6478793e678ac 732928 rapmap_0.12.0+dfsg-1_amd64.deb
Files:
 aaf9e6cf1a9bd97e4d5391d7bbf0e822 2275 science optional rapmap_0.12.0+dfsg-1.dsc
 3d0c0771498411b4b6fc24532b3b58f3 547544 science optional rapmap_0.12.0+dfsg.orig.tar.xz
 0d804926c3cf35b314e059544757592a 9692 science optional rapmap_0.12.0+dfsg-1.debian.tar.xz
 dda15c4cb710c31fc6cff3d0ff67e6ee 7533028 debug optional rapmap-dbgsym_0.12.0+dfsg-1_amd64.deb
 54d2cc864d49fca6acf73b01a254a7c9 98384 science optional rapmap-dev_0.12.0+dfsg-1_all.deb
 cc76dcf1302063d9f7ccb8e4c7531c9c 411640 science optional rapmap-example-data_0.12.0+dfsg-1_all.deb
 c7113f50850fc2647251035d10bff96c 8039 science optional rapmap_0.12.0+dfsg-1_amd64.buildinfo
 5fe2d086db53020f254a4ea86b741ea0 732928 science optional rapmap_0.12.0+dfsg-1_amd64.deb
-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAlwRhzQRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtE8mw/8DTsPIfPnnsSZK0i2xsWt4QkOjX1n7MnC
lrqFgt8S76H04NVluTgwMI7MxvHx1CW78l8fQlKNheQq/+9PZYlZyYkzaAWnmL3T
5k1MZKO5hwNyE/fhXuCUqtrDVmcDBMJ0tCcbH2E3GLlwcifGxQTkOCzmDdnn7JhP
+eA+vKFXYwzAcsTVidczSoc5nlwxy/UAEfRym0mPtX12sD6BQaNtqBZHQydg2/aP
uHVTqRxbzUk3ELeCp+0ZJsdysNjhUii4BBCVv+oEW6MPeuSYRD0Y7yLupczrVg1P
1azkTGjlApZrBET1PKuK05sB1dHeAAQST3tWgMy0S8gv0vAyqPBasrdN1w+/+qK2
1ygzcLFMfRR5G2ax3GGIo1/EQBIezY9OZF+0jC3w9w6r0dOB+CPN4hhwZMaId1IL
LbqFG7NAIsTzeoOSbyhFf33ZCWQQIx3bzB3zNZQwAxZXvq6Q/QrHqjbNhXloNSVh
kWdoqYgVVSLpa+C5gOm3s3B2W44o78eB9lQT/D/+mcELWJJXCDdEvPckq0HoPG5G
uI+dLBfeu4nmc/ZlsmIgSaUAtWHnu71djMuCBzpOIwfDYgoGbekucr7X38HrcCy1
x6t5N7EBDUGoRB2DcMjdss3ESb2Z4V3MhQ2gqQdbX7TrPFuIdXm5IQ7yrKpgQHEK
T37RHgpB05I=
=QprV
-----END PGP SIGNATURE-----

#909766#22
Date:
2018-12-13 10:34:08 UTC
From:
To:
Hi,

while I closed this bug in 0.12.0+dfsg-1 its probably more sensible
to keep this bug open since it contains all information that is
probably helpful to adapt the code to the new API of spdlog version
1.1 (now 1.2).

The severity of the bug is set to important.

The issue is recorded in

https://salsa.debian.org/security-tracker-team/security-tracker/blob/master/data/embedded-code-copies

Kind regards

       Andreas.

#909766#35
Date:
2018-12-13 10:44:01 UTC
From:
To: