- Package:
- src:nocache
- Source:
- nocache
- Submitter:
- Santiago Vila
- Date:
- 2024-08-03 12:06:09 UTC
- Severity:
- important
- Tags:
Dear maintainer: I tried to build this package in sid but it failed: -------------------------------------------------------------------------------- [...] debian/rules build-arch dh build-arch dh_update_autotools_config -a dh_autoreconf -a dh_auto_configure -a dh_auto_build -a make -j1 "INSTALL=install --strip-program=true" make[1]: Entering directory '/<<PKGBUILDDIR>>' cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -o cachedel cachedel.c cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -o cachestats cachestats.c cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -fPIC -c -o nocache.o nocache.c cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -fPIC -c -o fcntl_helpers.o fcntl_helpers.c cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -fPIC -c -o pageinfo.o pageinfo.c cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -pthread -shared -Wl,-soname,nocache.so -o nocache.so nocache.o fcntl_helpers.o pageinfo.o -ldl sed 's!##libdir##!$(dirname "$0")!' <nocache.in >nocache chmod a+x nocache make[1]: Leaving directory '/<<PKGBUILDDIR>>' debian/rules override_dh_auto_test make[1]: Entering directory '/<<PKGBUILDDIR>>' ## #916415 timeout 11 ./nocache apt show coreutils 1>>/dev/null WARNING: apt does not have a stable CLI interface. Use with caution in scripts. make[1]: *** [debian/rules:21: override_dh_auto_test] Error 124 make[1]: Leaving directory '/<<PKGBUILDDIR>>' make: *** [debian/rules:10: build-arch] Error 2 dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2 -------------------------------------------------------------------------------- To be sure, I have tried to build the package 151 times on 8 different machines and it failed 151 times. Here are the full build logs: https://people.debian.org/~sanvila/build-logs/nocache/ A very similar failure happened here in mipsel, a release architecture: https://buildd.debian.org/status/fetch.php?pkg=nocache&arch=mipsel&ver=1.1-1&stamp=1546582253&raw=0 If you need help to reproduce this, please say so, I would gladly offer access to a system where this seems to happen all the time. Thanks.
tags 918316 + patch thanks The patch below works for me:--- a/debian/rules +++ b/debian/rules @@ -18,5 +18,5 @@ override_dh_auto_test: ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) # -NOCACHE_NR_FADVISE=2 dh_auto_test -v ## #916415 - timeout 11 ./nocache apt show coreutils 1>>/dev/null + timeout 60 ./nocache apt show coreutils 1>>/dev/null endif Note: I don't quite understand the purpose of the timeout. Is it really useful/required to set a timeout at all? Normally sbuild (the autobuilder program used by the build daemons) has already a built-in timeout mechanism which prevents the autobuilder to be stuck forever, and by looking at build logs from reproducible builds, I believe pbuilder has also a timeout by default. Thanks.
I get a different error here:
,----
| ## #916415
| timeout 11 ./nocache apt show coreutils 1>>/dev/null
| apt: nocache.c:148: init_mutexes: Assertion `fds_lock != NULL' failed.
| Aborted
| make[1]: *** [debian/rules:21: override_dh_auto_test] Error 134
`----
Increasing the timeout to 60 as you suggested does not help.
Cheers,
Sven
Hello, Bug #918316 in nocache reported by you has been fixed in the Git repository and is awaiting an upload. You can see the commit message below and you can check the diff of the fix at: https://salsa.debian.org/debian/nocache/commit/4cc35e3d2042b7f80bec7f31f7ed4d1fef329c75 ------------------------------------------------------------------------ rules: increase test timeout (Closes: #918316). Thanks, Santiago Vila. ------------------------------------------------------------------------ (this message was generated automatically) -- Greetings https://bugs.debian.org/918316
Hi Santiago, Thanks for the patch. I see, this issue is environment specific and seems to fail on sloe(er) machines like MIPS. In this case it is _necessary_. As you could notice from comment, this is a regression test for #916415. Timeout is required because process never exit (hangs) when test fails. Timeout here is to abort a particular test if/when it fails. It is better to fail quickly (within a minute) rather than needlessly occupy builder for an hour.--- A man does what he must - in spite of personal consequences, in spite of obstacles and dangers and pressures - and that is the basis of all human morality. -- Winston Churchill
Exit code suggests that APT is not happy hence timeout have nothing to do with that so I suspect this is unrelated to "nocache". Can you reproduce manually by "apt show coreutils"? Also, on which architecture is this? Thanks.--- You have to start with the truth. The truth is the only way that we can get anywhere. Because any decision-making that is based upon lies or ignorance can't lead to a good conclusion. -- Julian Assange, 2010
Control: clone -1 -2
Control: retitle -2 nocache.c:148: init_mutexes: Assertion `fds_lock != NULL' failed.
Control: severity -2 normal
That is unrelated to Santiago's problem, and I should have reported it
separately. Creating a new clone now, will followup when I have the
cloned bug's number.
Cheers,
Sven
As systemd increased the limits again¹, nocache is now unusable. It's
the
| apt: nocache.c:148: init_mutexes: Assertion `fds_lock != NULL' failed.
issue, triggered as simple as issuing "nocache true" - unless the system
has several Gigabytes of RAM. As systemd certainly will not move,
nocache has to. I'll check out the upstream change and will prepare an
NMU upon success.
Christoph
¹ https://lists.debian.org/msgid-search/a77c773c1e8cbeadeefbd30f21e7bbeb21a9d9bc.camel@debian.org
Dear maintainer,
to fix the issues with this package, I've prepared an NMU for nocache
(versioned as 1.1-1.1), debdiff below. An upload to DELAYED/5 will
follow shortly. Please feel free to tell me if I should delay it
longer.
Regards,
Christoph
Christoph Biedl wrote...
Not going to upload this, NMU doesn't make sense without fixing #1069426
as well.
Christoph
Hi! * Christoph Biedl [Sun Jun 09, 2024 at 09:47:25PM +0200]: The fix from Guillem that got pushed to upstream at https://github.com/Feh/nocache/pull/55 is meant to address #1069426. AFAICT upstream of nocache doesn't seem to be really active those days. Maybe it would make sense to incorporate this change into the Debian package to fix the FTBFS and get the package back into Debian testing? regards -mika-
Dear maintainer,
to fix the issues with this package, I've prepared an NMU for nocache
(versioned as 1.2-0.1), debdiff below. An upload to DELAYED/5 will
follow shortly. Please feel free to tell me if I should delay it
longer.
As already mentioned earlier in #1069426, I figured it was saner to
forward to the latest upstream release. The changes upstream have been
dropped from the debdiff to keep it short.
Regards,
Christoph
We believe that the bug you reported is fixed in the latest version of
nocache, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 918316@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Christoph Biedl <debian.axhn@manchmal.in-ulm.de> (supplier of updated nocache package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sun, 07 Jul 2024 13:44:09 +0200
Source: nocache
Architecture: source
Version: 1.2-0.1
Distribution: unstable
Urgency: medium
Maintainer: Dmitry Smirnov <onlyjob@debian.org>
Changed-By: Christoph Biedl <debian.axhn@manchmal.in-ulm.de>
Closes: 918316 1069426
Changes:
nocache (1.2-0.1) unstable; urgency=medium
.
* Non-maintainer upload
* Import upstream version 1.2, this fixes issues with increased file
limits. Closes: 918316
* Fix build on (most) 32 bit architectures. Closes: #1069426
Kudos to Guillem Jover for taking care of that.
* Simplify test so it will not time out. Closes: #918316 (again)
Checksums-Sha1:
c641548bc92f297c21ac5e0e89a175066654d436 1795 nocache_1.2-0.1.dsc
231950fac6981c8f9313810f9172fdb927397e4b 11768 nocache_1.2.orig.tar.xz
836b39500a1a6985326515c743fd8531f77cee64 7104 nocache_1.2-0.1.debian.tar.xz
11fcf50d22979b11775a5e776e3d7ca6b33e2336 5815 nocache_1.2-0.1_armel.buildinfo
Checksums-Sha256:
0acf53071e85a2e8c6b0519eec68cfb3baad883dfd05189a327c5be380635067 1795 nocache_1.2-0.1.dsc
1d190b21fdca0dc160b4249e6825275354dcb7a95a02aa845344e1fa83c8deba 11768 nocache_1.2.orig.tar.xz
0fe56b200982d2644fb4ea6a878f7d279962602aefea19a9da2b0fbbc1815c56 7104 nocache_1.2-0.1.debian.tar.xz
194f3f7499632d6fa60a00e715dde7d3a417ead798f32bc8f00df74782267e5d 5815 nocache_1.2-0.1_armel.buildinfo
Files:
f08358bc194fc9079c0595fb32bfdb31 1795 utils optional nocache_1.2-0.1.dsc
f2ccf0c72dcd8d897a9b8c1d24b979a2 11768 utils optional nocache_1.2.orig.tar.xz
47e1e1981303579ef9452096f19d5a29 7104 utils optional nocache_1.2-0.1.debian.tar.xz
b265efbc19b66754580fb4ca018c990b 5815 utils optional nocache_1.2-0.1_armel.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEWXMI+726A12MfJXdxCxY61kUkv0FAmaK0DkACgkQxCxY61kU
kv1QCg/+MYphpwmpokMXh9sddr84yFyYDBhTmVbrMa8JbFRL3XJybtP8VOMnlVUg
zn5d5Sj2Ez3jkTBCPFjQCoxY1xIvV2x9oCplEj+6O6Kuw9hSzcu5gKqtOMvpDCcN
4zSp+U3ZvG6rw0PDOxmsff8wcJf528AEGoSEX99d3NMQR3/8myfzQWURWlg6E/jc
3xJD8a9vYoxiQO9q1S5RNsK5JkcBRejDMZELzwd3YE/yA03vlnRghcaXK5SUcrYT
HjjxOjY6ouBSfl9t+P0PrkaJpuz4Xa3YeRmRVoCIi7bh4OAGxtl8EvltB43rMYVf
8iy6VFU+6wqFvbs9Jj1iOl2xCcoKq+sSTIw5IZBTRIrh9DCzdtuOjYq/8uu2vvfs
Vl/yjRLn28alw6nhcW4byoafIVqIk6erlpZmrjMI34ZWH4r7H1o3GRWVMyvh6pLs
P5flDzHQMgvKQFpK1GHOgsiQ85N9x3ynXm/E9jB1lTVnBPw+tsA227e9Ou4SQ+KY
qimnqfpiP2MXKyuc4FghbQdEkfAJc5rr+2nSOGhmw6MkNo13puHagg5EDcCLWqTB
yqcPsA6Wiot8ESC2zuxVxECecTHxpyC9LJMMxQul7qREFextZrrmefy2wN9xO7pF
Ki8u+IqiF22VRR9FdGMq3FVu55OZtMpI+l41ofpBt1tOCs+egeE=
=AhtP
-----END PGP SIGNATURE-----