Package: radvd
Version: 2.17-1


debian/rules has
  export DEB_BUILD_OPTIONS=nocheck
for an unknown reason.  Unknown for me, the current maintainer.

Lintian warns about it.
That warning is being overriden.
But that does NOT solve the problem of the disabled checks.

This bugreport is tracking further work on this issue.


Groeten
Geert Stappers

tags 919926 patch
thanks

Hello Geert.

The reason this package disables the tests is that they do not work.
More specifically, "make check" tries to build some programs and the
compilation fails with this linking error:

./test/util.c:264:(.text+0x51): undefined reference to `_mark_point'
/usr/bin/x86_64-linux-gnu-ld.bfd: check_all-util.o: in function `iface_setup':
./test/util.c:179:(.text+0xde): undefined reference to `_mark_point'
/usr/bin/x86_64-linux-gnu-ld.bfd: check_all-util.o: in function `test_safe_buffer_list_fn':
./test/util.c:83:(.text+0x5ec): undefined reference to `_mark_point'
/usr/bin/x86_64-linux-gnu-ld.bfd: check_all-util.o: in function `test_check_dnssl_presence_fn':
./test/util.c:198:(.text+0x76f): undefined reference to `_mark_point'
/usr/bin/x86_64-linux-gnu-ld.bfd: check_all-util.o: in function `test_safe_buffer_fn':
./test/util.c:23:(.text+0x990): undefined reference to `_mark_point'
/usr/bin/x86_64-linux-gnu-ld.bfd: check_all-util.o:./test/util.c:223: more undefined references to `_mark_point' follow
collect2: error: ld returned 1 exit status


So disabling the tests is currently necessary and justified.

However, there is a problem in the way the tests are skipped.
The package uses DEB_BUILD_OPTIONS in debian/rules, which triggers
a lintian warning. I agree with lintian here. The DEB_BUILD_OPTIONS
variable is reserved to be used by whoever is building the package,
not by debian/rules.

In this particular case, we want the tests not to run during build,
because they do not work, and we already have a good way to do that,
which is to have a rule called override_dh_auto_test which does
nothing.

Please consider the attached patch, which also removes the
lintian override, as it becomes no longer necessary.

[ Note: Not sure if this bug was about tracking how to re-enable the tests,
  or about why the tests are disabled in the specific way they are
  currently disabled, causing a lintian warning etc.

  So, feel free to drop the Closes statement in the attached patch if
  you still want to keep this bug open with the meaning "I would like
  to run the tests" ].

Thanks.