#926128 u-boot-menu: should stop with error if failing

#926128#5
Date:
2017-07-15 14:38:01 UTC
From:
To:
Entries in extlinux.conf contain this line:

fdtdir /usr/lib/linux-image-4.9.0-3-armmp-lpae

But it should be /dtb-4.9.0-3-armmp-lpae

This error make the menu unusable. No matter what entry you choose, file to load
dtb file and u-boot fallback to boot.scr for loading the images.

Thanks,
  Diego Roversi

#926128#10
Date:
2017-07-15 18:32:50 UTC
From:
To:
severity 868454 minor
thanks

Thanks for trying out u/boot menu.

This is correct path. That is where the kernel package installs dtbs to.

I think you have a partition setup where /boot is a separate
partition. This is unfortunately
not supported at the moment. You need to set up fdtdir setting in
/etc/default/u-boot file to fit
your setup.

Riku

#926128#17
Date:
2017-07-16 07:53:19 UTC
From:
To:
On Sat, 15 Jul 2017 21:32:50 +0300 Riku Voipio <riku.voipio@linaro.org> wrote:

Hello Riku,

A separate /boot is the standard layout used in debian-installer. So I think is important to support it.

Also, I see there is no /etc/default/u-boot, so can be useful to add it to the package as a empty template.

Thanks,
  Diego.

#926128#22
Date:
2017-07-18 12:40:21 UTC
From:
To:
I added this line to the /etc/default/u-boot:

U_BOOT_FDT_DIR="/dtbs/"

but the script generate an empty line instead of the fdtdir line.

The problem is  still due to the /boot being in a separate partition. The
script have already has some logic to handle a separated boot partition, but
is not used for the fdtdir.

I propose the following patch:
--- /usr/sbin/u-boot-update 2017-06-26 07:47:08.000000000 +0200 +++ u-boot-update 2017-07-18 14:09:56.831731116 +0200 @@ -135,11 +135,15 @@ if [ "$(stat --printf %d /)" = "$(stat --printf %d /boot)" ] then + #_BOOT_DIRECTORY is the boot directory for u-boot at boot time + #_BOOT_PATH is where is mounted the boot directory after boot # / and /boot are on the same filesystem _BOOT_DIRECTORY="/boot" + _BOOT_PATH="/" else # / and /boot are not on the same filesystem _BOOT_DIRECTORY="" + _BOOT_PATH="/boot/" fi @@ -156,10 +160,10 @@ else _INITRD="" fi - if [ -e ${U_BOOT_FDT_DIR}${_VERSION}/${U_BOOT_FDT} ] && [ -n "${U_BOOT_FDT}" ] + if [ -e ${_BOOT_PATH}${U_BOOT_FDT_DIR}${_VERSION}/${U_BOOT_FDT} ] && [ -n "${U_BOOT_FDT}" ] then _FDT="fdt ${U_BOOT_FDT_DIR}${_VERSION}/${U_BOOT_FDT}" - elif [ -d ${U_BOOT_FDT_DIR}${_VERSION}/ ] + elif [ -d ${_BOOT_PATH}/${U_BOOT_FDT_DIR}${_VERSION}/ ] then _FDT="fdtdir ${U_BOOT_FDT_DIR}${_VERSION}/" else Also, the script should stop with a error message, if a file or a directory is not found, so it will not create a invalid configuration file. Thanks, Diego
#926128#27
Date:
2019-03-31 10:48:57 UTC
From:
To:
Dear Riku,

Are you still interested in maintaining the package u-boot-menu?

I notice that your last upload was 1.5 years ago, and you have not
addressed nor commented on any of the 3 bugs filed since then (where one
of them - 908593 - arguably addresses also the last bug - 868454 - which
you did comment on).

If interested but need a little help, then you might find useful my
slight fork of the package, addressing those 3 (or 4) bugs, at
https://salsa.debian.org/js/u-boot-menu

I can offer to co-maintain or take over maintenance, if you like.

 - Jonas

#926128#32
Date:
2019-03-31 11:41:44 UTC
From:
To:
Hi Jonas,

Please go for it! I'm never offended if people fix bugs in my packages :)

Riku

#926128#37
Date:
2019-03-31 13:40:21 UTC
From:
To:
Quoting Riku Voipio (2019-03-31 13:41:44)

Excellent!

I gave a few options and interpret your response as "do what you prefer"
- so I will add myself as co-maintainer, release my slight fork to
unstable, and ask release managers to consider accepting it for Buster.

Please do chime in if you disagree with any of that.

Thanks,

 - Jonas

#926128#42
Date:
2019-03-31 13:47:18 UTC
From:
To:
Quoting Jonas Smedegaard (2019-03-31 15:40:21)

s/co-maintainer/uploader/

...and I will move maintenance to debian area at salsa.debian.org.


 - Jonas

#926128#47
Date:
2019-03-31 19:32:25 UTC
From:
To:
control: clone 868454 -1 -2 -3
control: retitle 868454 u-boot-menu: unusable with separate /boot partition
control: forcemerge 868454 908590
control: retitle -1 u-boot-menu: should try flash-kernel path with separate /boot partition
control: retitle -2 u-boot-menu: /etc/default/u-boot not installed
control: retitle -3 u-boot-menu: should stop with error if failing

This bugreport contain multiple issues, better tracked separately.

Also, sorry for not understanding at the time that (main part of) this
bugreport was the same as I later reported as bug#908590.


Thanks,

 - Jonas

#926128#56
Date:
2019-12-08 14:01:02 UTC
From:
To:
Hi Diego,

Thanks a lot for your many suggestions!

I split your reported suggestions into separate issues, and believe most
are now fixed except this one:

Do you agree that above is now the only open issue left?

If you want, then it is helpful if you could propose a patch for this
issue.


You are quite welcome to continue to report issues - with or without
patches.  Best if you file each issue separately, however: It is easier
and less confusing to later merge issues than to split them up.

Kind regards,

 - Jonas