#926189 rmagic does not compile with Perl5 v26 because of an unescaped left angle brace

Package:
rmagic
Source:
rmagic
Submitter:
Christopher Lansdown
Date:
2024-10-22 08:24:02 UTC
Severity:
normal
Tags:
#926189#5
Date:
2019-04-01 17:53:45 UTC
From:
To:
With Perl5 v26, rmagic no longer compiles (as in, perl -c /usr/bin/rmagic returns errors)

Line 322 is:

        $statistics{Log_File} =~ s/\${infile}/$infile/gi;

But unescaped angle braces are no longer deprecated in Perl5 v26, but simply fail to compile
Accordingly, line 322 should be:

       $statistics{Log_File} =~ s/\$\{infile\}/$infile/gi;

This problem is specific to the perl version (Perl5 v26 is the default in Ubuntu 18.04, which I'm using) and is not OS or hardware dependent.

Many thanks,
Christopher Lansdown
#926189#10
Date:
2024-10-22 08:20:49 UTC
From:
To:
Hi Christopher,

I stumbled about the package rmagic and wanted to fix the open bugs.
I'm not a Perl expert.  I tried to reproduce the issue under current
testing:


rmagic(master) $ perl -c /usr/bin/rmagic
/usr/bin/rmagic syntax OK

rmagic(master) $ perl -v
This is perl 5, version 38, subversion 2 (v5.38.2) built for x86_64-linux-gnu-thread-multi
(with 44 registered patches, see perl -V for more detail)
...


So it seems that the current version of Perl is tolerant against
the expression that failed in version 26.  Would you recommend
to apply your patch anyway?

Kind regards
    Andreas.