Hi!

firebird3.0 currently fails to build from source on m68k because the native
alignment of 16 bits on this architecture causes the on-disk structures to
have unexpected sizes.

With the attached patch, padding is added to the affected on-disk structures
such that the correct sizes are always guaranteed. Since this particular
padding happens automatically and implicitly for architectures with 32 or
64 bits native alignment, the actual sizes and offsets of the on-disk
structures do not change and therefore no compatibility break is going
to occur.

Using explicit padding has the advantage that the actual sizes and offsets
are completely visible and transparent to anyone reading the code.

I will forward this patch upstream.

Thanks,
Adrian

Hello Adrian,

Sorry for the late reply.

-=| John Paul Adrian Glaubitz, 15.07.2019 00:41:49 +0200 |=-

Can you tell me where was the patch forwarded? I want to check whether
it is part of some upstream branch before applying it to the debian
package.


Thanks,
    Damyan

Hi Damyan!

Patch and discussion can be found here [1].

However, it turns out that my approach is wrong and upstream has already used
a different approach for firebird4.0 [2], although I haven't tested that on
m68k yet.

Will test later.

Adrian