#934231 anacron: please provide a runscript for runit

Package:
anacron
Source:
anacron
Description:
cron-like program that doesn't go by time
Submitter:
Lorenzo Puliti
Date:
2019-09-24 21:54:05 UTC
Severity:
wishlist
#934231#5
Date:
2019-08-08 12:11:48 UTC
From:
To:
Dear QA Group,

here is a patch (attached) to add support for Runit initialization system.
There is also a MR on Salsa:
https://salsa.debian.org/debian/anacron/merge_requests/1

If you need more details please ask

Thanks,
Lorenzo
#934231#10
Date:
2019-09-04 17:30:23 UTC
From:
To:
Hi,
I have updated the patches and the MR:
First patch adds Gtilab CI test and include a test for the runscript

https://salsa.debian.org/Lorenzo.ru.g-guest/anacron/pipelines/69420

The second one, compared to the previuos version, adds the following:
 * bump dh-runit version to 2.8.14 in Build-depends
 * add presubj option for dh-runit
 * slightly reword the echo messages in run and finish files

Thanks,
Lorenzo
#934231#15
Date:
2019-09-08 19:17:18 UTC
From:
To:
[2019-09-04 19:30] Lorenzo Puliti <lorenzo.ru.g@gmail.com>

Hi,

I see all test jobs pass, not just `daemons'. Great!

There is nothing in this script specific to anacron. I propose
following:

 * add this finish script into bin:runit as /lib/runit/finish-default or
   something like this.

 * document error codes (161, 160, -1, etc) in invoke-run manpage.

 * modify dh_runit to generate finish script with following content:

   #!/bin/sh
   /lib/runit/finish-default

   Not sure should it be default or yet-another option.

This is more work initially, but will make improvements to finish script
transparent (just upgrade bin:runit), should need appear and avoid
copy-paste work for future runscripts.

FWIW, every time I thought "there will be no need to change <foo>", I
was wrong.
advices aganist use of `-a` option:

NOTE:  Binary  -a  and -o are inherently ambiguous.  Use 'test EXPR1 &&
       test EXPR2' or 'test EXPR1 || test EXPR2' instead.

Minor style issue. Trailing whitespace. You may want to enable default
git pre-commit hook, which catches such issues.

Why? Will it work correctly on machine that is up for 24/7?

Minor style issue. Please keep spacing consistent, like

	foo (>= 1.2.3-4~5)
#934231#20
Date:
2019-09-24 21:49:10 UTC
From:
To:
Il giorno dom 8 set 2019 alle ore 21:17 Dmitry Bogatov <KAction@disroot.org>
ha scritto:
detects that
there are no job to run it exits again. For machines up 24/7 the package
ships
a cronjob, so it will work.

I think I have addressed (on salsa) other issues except the finish file: I
will open a bug with a
patch for that but i'm short on free time right now.

Lorenzo