#941270 Private headers of qtlocation5 are not packaged

Package:
qtlocation5-dev
Source:
qtlocation-opensource-src
Description:
Qt 5 Location development files
Submitter:
Helge Bahmann
Date:
2019-09-27 12:39:08 UTC
Severity:
normal
#941270#5
Date:
2019-09-27 12:36:47 UTC
From:
To:
The private header files of this Qt module are not packaged. This is inconsistent with
other Qt modules (e.g. qtbase5-private-dev), and some programs need them for
compilation.

Suggest packaging them up as for other Qt libraries as well, patch to packaging is
available here: https://pastebin.com/HQNARwJm

Also attached below...

Thanks!

diff --new-file -u -r qtlocation-opensource-src-5.11.3+dfsg.orig/debian/control qtlocation-opensource-src-5.11.3+dfsg/debian/control
--- qtlocation-opensource-src-5.11.3+dfsg.orig/debian/control	2019-09-05 11:59:30.511475145 +0200
+++ qtlocation-opensource-src-5.11.3+dfsg/debian/control	2019-09-05 11:48:29.171710602 +0200
@@ -205,3 +205,46 @@
  .
  This package contains the HTML documentation for the Qt 5 Positioning
  libraries and binaries.
+
+Package: qtlocation5-private-dev
+Architecture: any
+Multi-Arch: same
+Section: libdevel
+Depends: qtlocation5-dev (= ${binary:Version}), ${misc:Depends}
+Description: Qt 5 location private development files
+ Qt is a cross-platform C++ application framework. Qt's primary feature
+ is its rich set of widgets that provide standard GUI functionality.
+ .
+ This package contains the private header development files for building some
+ Qt 5 applications using Qt 5 location private headers.
+ .
+ Use at your own risk.
+
+Package: qtpositioning5-private-dev
+Architecture: any
+Multi-Arch: same
+Section: libdevel
+Depends: qtpositioning5-dev (= ${binary:Version}), ${misc:Depends}
+Description: Qt 5 positioning private development files
+ Qt is a cross-platform C++ application framework. Qt's primary feature
+ is its rich set of widgets that provide standard GUI functionality.
+ .
+ This package contains the private header development files for building some
+ Qt 5 applications using Qt 5 positioning private headers.
+ .
+ Use at your own risk.
+
+Package: qtpositioningquick5-private-dev
+Architecture: any
+Multi-Arch: same
+Section: libdevel
+Depends: qtpositioningquick5-dev (= ${binary:Version}), ${misc:Depends}
+Description: Qt 5 positioningquick private development files
+ Qt is a cross-platform C++ application framework. Qt's primary feature
+ is its rich set of widgets that provide standard GUI functionality.
+ .
+ This package contains the private header development files for building some
+ Qt 5 applications using Qt 5 positioningquick private headers.
+ .
+ Use at your own risk.
+
diff --new-file -u -r qtlocation-opensource-src-5.11.3+dfsg.orig/debian/not-installed qtlocation-opensource-src-5.11.3+dfsg/debian/not-installed
--- qtlocation-opensource-src-5.11.3+dfsg.orig/debian/not-installed	1970-01-01 01:00:00.000000000 +0100
+++ qtlocation-opensource-src-5.11.3+dfsg/debian/not-installed	2019-09-05 11:57:06.506801713 +0200
@@ -0,0 +1,2 @@
+usr/lib/x86_64-linux-gnu/cmake/Qt5Positioning/Qt5Positioning_QGeoPositionInfoSourceFactorySerialNmea.cmake
+usr/lib/x86_64-linux-gnu/qt5/plugins/position/libqtposition_serialnmea.so
diff --new-file -u -r qtlocation-opensource-src-5.11.3+dfsg.orig/debian/qtlocation5-private-dev.install qtlocation-opensource-src-5.11.3+dfsg/debian/qtlocation5-private-dev.install
--- qtlocation-opensource-src-5.11.3+dfsg.orig/debian/qtlocation5-private-dev.install	1970-01-01 01:00:00.000000000 +0100
+++ qtlocation-opensource-src-5.11.3+dfsg/debian/qtlocation5-private-dev.install	2019-09-05 11:48:23.411361640 +0200
@@ -0,0 +1,2 @@
+usr/include/*/qt5/QtLocation/*/QtLocation/private/*
+usr/lib/*/qt5/mkspecs/modules/qt_lib_location_private.pri
diff --new-file -u -r qtlocation-opensource-src-5.11.3+dfsg.orig/debian/qtpositioning5-private-dev.install qtlocation-opensource-src-5.11.3+dfsg/debian/qtpositioning5-private-dev.install
--- qtlocation-opensource-src-5.11.3+dfsg.orig/debian/qtpositioning5-private-dev.install	1970-01-01 01:00:00.000000000 +0100
+++ qtlocation-opensource-src-5.11.3+dfsg/debian/qtpositioning5-private-dev.install	2019-09-05 11:48:23.411361640 +0200
@@ -0,0 +1,2 @@
+usr/include/*/qt5/QtPositioning/*/QtPositioning/private/*
+usr/lib/*/qt5/mkspecs/modules/qt_lib_positioning_private.pri
diff --new-file -u -r qtlocation-opensource-src-5.11.3+dfsg.orig/debian/qtpositioningquick5-private-dev.install qtlocation-opensource-src-5.11.3+dfsg/debian/qtpositioningquick5-private-dev.install
--- qtlocation-opensource-src-5.11.3+dfsg.orig/debian/qtpositioningquick5-private-dev.install	1970-01-01 01:00:00.000000000 +0100
+++ qtlocation-opensource-src-5.11.3+dfsg/debian/qtpositioningquick5-private-dev.install	2019-09-05 11:48:23.411361640 +0200
@@ -0,0 +1,2 @@
+usr/include/*/qt5/QtPositioningQuick/*/QtPositioningQuick/private/*
+usr/lib/*/qt5/mkspecs/modules/qt_lib_positioningquick_private.pri
diff --new-file -u -r qtlocation-opensource-src-5.11.3+dfsg.orig/debian/rules qtlocation-opensource-src-5.11.3+dfsg/debian/rules
--- qtlocation-opensource-src-5.11.3+dfsg.orig/debian/rules	2019-09-05 11:59:17.456125310 +0200
+++ qtlocation-opensource-src-5.11.3+dfsg/debian/rules	2019-09-05 11:47:48.025263340 +0200
@@ -21,12 +21,6 @@

 	# Remove libtool-like files
 	rm -f debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/*.la
-
-	# Remove private stuff
-	rm -rfv $(CURDIR)/debian/tmp/usr/include/$(DEB_HOST_MULTIARCH)/qt5/QtLocation/*/QtLocation/private
-	rm -rfv $(CURDIR)/debian/tmp/usr/include/$(DEB_HOST_MULTIARCH)/qt5/QtPositioning/*/QtPositioning/private
-	rm -rfv $(CURDIR)/debian/tmp/usr/include/$(DEB_HOST_MULTIARCH)/qt5/QtPositioningQuick/*/QtPositioningQuick/private
-	rm -fv $(CURDIR)/debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/qt5/mkspecs/modules/qt_lib_*_private.pri

 	# Remove binary that includes libtheora in itself
 	rm -f debian/tmp/usr/lib/*/qt5/examples/qtlocation/declarative/mapviewer/qml_location_mapviewer
diff --new-file -u -r qtlocation-opensource-src-5.11.3+dfsg.orig/debian/not-installed qtlocation-opensource-src-5.11.3+dfsg/debian/not-installed
--- qtlocation-opensource-src-5.11.3+dfsg.orig/debian/not-installed	2019-09-05 11:59:17.456125310 +0200
+++ qtlocation-opensource-src-5.11.3+dfsg/debian/not-installed	2019-09-05 11:47:48.025263340 +0200
+usr/lib/x86_64-linux-gnu/cmake/Qt5Positioning/Qt5Positioning_QGeoPositionInfoSourceFactorySerialNmea.cmake
+usr/lib/x86_64-linux-gnu/qt5/plugins/position/libqtposition_serialnmea.so