#941811 please convert package to use dh-elpa for perlcritic.el

#941811#5
Date:
2019-10-05 21:42:36 UTC
From:
To:
Dear maintainer,

I've confirmed this affects 1.134-1.  Please convert
libperl-critic-perl to use dh-elpa for perlcritic.el.  It handles byte
compilation which the package in buster lacks.

It looks like emacsen-startup is Debian-specific customisation.  That
will go in the debian-autoloads.el file.  See § "Debian-specific Lisp customizations" (man dh_elpa).


Regards,
Nicholas

#941811#10
Date:
2019-10-05 22:18:08 UTC
From:
To:
hi Nicholas,

it looks we did that back in

libperl-critic-perl (1.092-1) unstable; urgency=low
[...]
  * install perlcritic.el into site-lisp, add debian/emacsen-startup
    adds perlcritic mode to Emacs. Thanks to Kevin Ryde for the suggestion and
    the patch. Closes: #483288

Would you be open to help providing this conversion?

Regards,
Salvatore

#941811#15
Date:
2019-10-06 00:55:15 UTC
From:
To:
Hi Salvatore,

Salvatore Bonaccorso <carnil@debian.org> writes:

Yes, absolutely; however, I expect to be swamped with work for the next
week or two.  Here's an example of a moderately complex case of similar
file-mode.el bundled in upstream src:package, with atomic commits for
each operation:

https://salsa.debian.org/sten-guest/tuareg-mode/commits/master

The biggest changes are perlcritic.el is added to
"debian/elpa-perlcritic.elpa", with some definitions in d/control, plus
the Debian-specific customisation I noted previously.  Breaks & replaces
are essential, but please omit provides in this case.  The
elpa-perlcritic.pkg file might need a hint for successful generation.
#debian-emacs is a friendly team too, so feel free to drop by even if
I'm not there :-)


Happy hacking,
Nicholas