#942825 dphys-swapfile: Avoid fallocate on f2fs, fix detection of fallocate command.

Package:
dphys-swapfile
Source:
dphys-swapfile
Submitter:
Cyrill Helg
Date:
2019-10-23 22:57:03 UTC
Severity:
important
#942825#5
Date:
2019-10-22 05:55:52 UTC
From:
To:
Dear Maintainer,

please update the part of detecting fallocate as the exit code of the type command causes the script to stop if fallocate is not found.
Please also avoid using fallocate in case of f2fs by checking the filesystem type.
Both corrections are implemented already, see the patch.
#942825#10
Date:
2019-10-22 14:25:47 UTC
From:
To:
Hi Cyrill,

Cyrill Helg wrote:
[...]

fallocate is no more used since dphys-swapfile 20100506-5 as it
does only work on specific file systems and mkswap explicitly
recommends to not use it.

Do you think we should reinstatiate that Debian- (and derivatives)
specific patch which has not been accepted upstream and add your patch
on top plus a either a whitelist filesystems which work with fallocate
(preferred) or a blacklist of filesystems which don't work (your
suggestion)?

		Regards, Axel
#942825#17
Date:
2019-10-22 14:42:23 UTC
From:
To:
Hi Axel

Yes I think we should try that. If fallocate is not recommended at all, we
could just entirely get rid of the if clause? This would simplify things,
i.e. we wouldn't need the whitelist.

Best regards
Cyrill