#946152 please update build-deps on iptables

Package:
src:collectd
Source:
collectd
Submitter:
Arturo Borrero Gonzalez
Date:
2022-01-19 20:21:03 UTC
Severity:
normal
Tags:
#946152#5
Date:
2019-12-04 11:44:21 UTC
From:
To:
Hi there!

The src:iptables debian package (v1.8.4-1) dropped the libiptc-dev and libiptc0
binary packages. The content is included now in either libip4tc or libip6tc.
Such change comes from upstream.

This package seems to `#include <libiptc/libiptc.h>`, which is fine; But
I encourage to please update the build-deps to use libip4tc-dev instead of
libiptc-dev.

The header file is the same. Also pkg-config information should be right.

The build should be something like:

	gcc $(pkg-config xtables --cflags) yourpackage.c -lip4tc or -lip6tc

instead of:

	gcc yourpackage.c -liptc

This may need reporting upstream. Let me know if you find any issue with this
change.

#946152#16
Date:
2020-03-01 14:18:22 UTC
From:
To:
I'm trying to address the changes in the iptables package for collectd.

I can avoid the dependency on the transitional iptables-dev package (see [1]), but I'm confused by the
statement:

I see that libiptc0 is a transitional dummy package, but libiptc-dev is not indicated to be obsolete, and
in fact contains the pkg-config file

/usr/lib/x86_64-linux-gnu/pkgconfig/libiptc.pc

Is there another package that collectd should build-depend on for this file? (I.e., have I incorrectly
merged 946152 and 951088?) Or is the removal of the dependency on libiptc0 (by rebuilding) sufficient to
address your original bug report?

Thanks,
Antonio Russo

[1] https://salsa.debian.org/debian/pkg-collectd/-/merge_requests/2

#946152#25
Date:
2020-03-01 17:46:26 UTC
From:
To:
Sorry for the noise here. I understand that these are two separate issues, and I believe
that upstream has addressed the libiptc -> libip4tc name change in their 5.10.0 release.

My MR has been updated to only pull in libip4tc-dev and libip6tc-dev, and not libiptc-dev
in a third patch, so there is still a patch pending to fix this.

Antonio

#946152#32
Date:
2020-03-06 23:50:40 UTC
From:
To:
I fail to understand the reason behind this: libiptc-dev still exists
and collectd needs it to build successfully. Please convince me why
there is a reason for this change.

#946152#37
Date:
2020-03-07 01:11:30 UTC
From:
To:
and "pkg-config --exists libip4tc" in the configure.ac file in the collectd
5.10 release---but my eyes must have been misled, because that is not the
case.

Because that is not the case, the pkg-config calls to get the path to
libip4tc{.h,.so} libip6tc{.h,.so} and libiptc.h fail. You can get around
that with the trivial patch I've attached.

As for the question "Why can't we just use libiptc-dev's version of the
pkg-config file that just works?" I don't know. But, if it becomes a
problem, this should work (it builds on my machine without libiptc-dev).

Best,
Antonio

#946152#42
Date:
2022-01-19 20:13:48 UTC
From:
To:
Hi,

sorry for the late reply!


Unfortunately the attached patch is for xvfb - and not collectd.
If possible just send an MR on salsa.

Bernd