#947044 ftpsync 20180513 from git sends invalid emails

Package:
archvsync
Source:
archvsync
Submitter:
Niklas Edmundsson
Date:
2021-08-16 10:42:02 UTC
Severity:
normal
Tags:
#947044#5
Date:
2019-12-19 20:32:24 UTC
From:
To:
When trying to upgrade our ftpsync installation to the latest one
downloaded via git we noticed that error emails sent by the new
version are shown as invalid by some mail readers.

This is caused by not quoting the boundary value in the MIME header.

The following patch fixes this problem (any tab characters are likely
mangled to regular spaces):

diff --git a/bin/common b/bin/common
index 7f3cc50..f4f4d94 100644
--- a/bin/common
+++ b/bin/common
@@ -389,7 +389,7 @@ Subject: ${subject}
  To: $(join_by ', ' "$@")
  Auto-Submitted: auto-generated
  MIME-Version: 1.0
-Content-Type: multipart/mixed; boundary=${boundary}
+Content-Type: multipart/mixed; boundary="${boundary}"

  EOF
          if [[ ${body[@]:-} ]]; then

#947044#10
Date:
2021-08-13 12:19:50 UTC
From:
To:
Hi,

I have attached a more complete patch which fixes some more encoding
errors.

Cheers,

#947044#15
Date:
2021-08-16 10:39:07 UTC
From:
To:
Hi,

thanks for the patch.

This line seems wrong, I assume it's meant to be
Content-Transfer-Encoding?  Also probably needs to come somewhere other
than after the attachment?

Cheers,
Julien