#947052 lintian: Add check for binNMU changelog entries in source packages

Package:
lintian
Source:
lintian
Submitter:
Guillem Jover
Date:
2019-12-20 04:27:04 UTC
Severity:
normal
#947052#5
Date:
2019-12-20 02:45:00 UTC
From:
To:
Hi!

I've already noticed at least two instances of maintainers fixing email
addresses due to debian-changelog-file-contains-invalid-email-address,
for binNMU entries in debian/changelog's in source packages.

These should never be in a source package's debian/changelog, as they
are arch-specific rebuilds, triggered by external forces, w/o
modification to the source package (except for the debian/changelog
entry so that it propagates to the built binary).

I assume these got merged at some time, following the otherwise common
practice of acknowleding NMUs by incorporating their changelog entries,
which should not apply for binNMUs.

So it seems counterproductive to emit the above tag, when these
entries should instead be removed. :)

Thanks,
Guillem
#947052#10
Date:
2019-12-20 03:07:04 UTC
From:
To:
Hi Guillem,

Just to clarify
Is this what you want me to do?

for all changelog entries:
if version indicates binNMU,
    tell user to delete entry
if version does not indicate binNMU,
    check email address for validity.

Kind regards
Felix
#947052#15
Date:
2019-12-20 04:20:56 UTC
From:
To:
Hi!

I'd change your algo a bit like this:
if version is binNMU and (is latest or previous is binNMU),
  ignore
if version is binNMU and previous is not binNMU,

Otherwise, yes!

Thanks,
Guillem