Dear Maintainer,

Fail to upgrade with this error :

Setting up openssh-server (1:8.1p1-5) ...
rescue-ssh.target is a disabled or a static unit, not starting it.
Failed to restart ssh.service: Unit -.mount is masked.
invoke-rc.d: initscript ssh, action "restart" failed.
* ssh.service - OpenBSD Secure Shell server
     Loaded: loaded (/lib/systemd/system/ssh.service; enabled; vendor preset: enabled)
     Active: active (running) since Sat 2020-01-11 08:26:51 CET; 1 day 6h ago
       Docs: man:sshd(8)
             man:sshd_config(5)
   Main PID: 1119 (sshd)
     Memory: 3.7M
     CGroup: /system.slice/ssh.service
             `-1119 /usr/sbin/sshd -D

Christian

Control: reassign -1 systemd 244-3

The OpenSSH units don't make any reference to a -.mount unit (explicitly
or implicitly, as far as I can tell), so I can only assume that this is
some kind of bug in systemd itself; reassigning over there.  Feel free
to reassign back if it seems that this is a bug in ssh.service after
all, but in that case I'd appreciate some kind of specific advice on
what it's doing wrong.

(I upgraded a test system that I deliberately keep in a clean state for
this sort of thing, and it worked fine for me.)

Hi Colin,

please CC the package on reassign.

The bug is, that someone or something has masked _.mount unit, which you
shouldn't do.

My guess is on gparted, which has done that in the past and I'm not sure
if it still does.

Christian, have you run/used gparted prior/while running the openssh
upgrade?

Control: clone -1 -2
Control: reassign -2 gparted 0.32.0-2
Control: retitle -2 gparted should not mask .mount units
Control: retitle -1 handle masked .mount unit more gracefully
Control: severity -1 important

That's not quite true. ssh.service (and the vast majority of services)
uses DefaultDependencies=yes (as it is the default behaviour).


This will generate a dependency on various .mount units, depending on
your /etc/fstab.

$ systemctl show ssh.service -p Requires -p After
Requires=system.slice -.mount sysinit.target
After=auditd.service system.slice basic.target systemd-journald.socket
network.target sysinit.target -.mount

 so I can only assume that this is

The ssh.service is doing nothing wrong.

I'd say we have two bugs here:

a/ a package or user doing something stupid like masking _.mount
b/ systemd not handling that case more gracefully.


I quickly checked the gparted sources and noticed that it still does
mask all .mount units.

gparted.in:	  | grep -v masked | cut -f1 -d' ' \
gparted.in:	systemctl --runtime mask --quiet -- $MOUNTLIST
gparted.in:	systemctl --runtime unmask --quiet -- $MOUNTLIST


So cloning and re-assinging the bug report.

Just wanted to note in this copy of the bug that the recommendation from
upstream systemd was that gparted should not be masking mounts but
instead should take a bsd lock on the device to prevent auto mounts.

Hello!

It looks like this particular issue has been fixed in gparted 1.2.0 which
was just released a few days ago [1]:

Might be an idea to update gparted to version 1.2.0 before the Bullseye freeze
which is coming in Mid-February [2].

Adrian

John Paul Adrian Glaubitz writes:

Thanks... on it.

Hi,

This new upstream version doesn't remove the code masking the systemd units.
It just changes it a little. So it doesn't fix this bug.

I don't know if there's already an upstream bug describing the issue, but that
might be needed to get the bug resolved upstream.

Cheers,

Ivo

We believe that the bug you reported is fixed in the latest version of
gparted, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 948739@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Phillip Susi <phill@thesusis.net> (supplier of updated gparted package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Fri, 29 Jan 2021 15:34:55 -0500
Source: gparted
Architecture: source
Version: 1.2.0-1
Distribution: unstable
Urgency: medium
Maintainer: Phillip Susi <phill@thesusis.net>
Changed-By: Phillip Susi <phill@thesusis.net>
Closes: 948739 950425
Changes:
 gparted (1.2.0-1) unstable; urgency=medium
 .
   [ nicoo ]
   * d/changelog: Update my name
 .
   [ Phillip Susi ]
   * New upstream version 1.2.0
     + Closes: #948739, #950425
   * Drop Reliably-detect-running-gpartedbin-using-pidof-54.patch
   * Update my email
Checksums-Sha1:
 e30e982d03ec23a10bf79619d038653254994c7d 1897 gparted_1.2.0-1.dsc
 61dbe956e6edbd489aad9bdb80f69b40b4f404a8 4057490 gparted_1.2.0.orig.tar.gz
 69fab34e2980175fbc27ca0ec9941d6186f381ed 488 gparted_1.2.0.orig.tar.gz.asc
 a572e20d139582ecaec0f11fcd74a1f76775211c 14788 gparted_1.2.0-1.debian.tar.xz
 97a9787b21071f7987ed92972d911fb2ff1e5ba2 15316 gparted_1.2.0-1_source.buildinfo
Checksums-Sha256:
 badc60df38eb5bf1dfc3db4bc104d376df2da23fca413e5f06c1d3f9cd5e555d 1897 gparted_1.2.0-1.dsc
 6c90715d254d7a7ec0208b29007b64160dd9fb7df4c4aa7f8ec2c9d23114c719 4057490 gparted_1.2.0.orig.tar.gz
 8ab5fc3b89d70026df73e228067f7f9e706fa05f4dbabe029434a793ca137822 488 gparted_1.2.0.orig.tar.gz.asc
 86ef94b92dbbb6bfa09bc03193c875594d22260e939454e44ad1741dde6e922d 14788 gparted_1.2.0-1.debian.tar.xz
 2925abee80d08cab06b5f507f700bb1fc3ee5f873cc1ec0acc6e9563b5f19e44 15316 gparted_1.2.0-1_source.buildinfo
Files:
 ae81912491baf528522f110b1bc10d73 1897 gnome optional gparted_1.2.0-1.dsc
 15166c40d7ca119432454475294abecf 4057490 gnome optional gparted_1.2.0.orig.tar.gz
 0001b149325ac123c0b50f64b64f8182 488 gnome optional gparted_1.2.0.orig.tar.gz.asc
 fad8c23f4ca7bf11f9b3c23d0fd9d6b0 14788 gnome optional gparted_1.2.0-1.debian.tar.xz
 b8f63b9546324027d6307f2852498897 15316 gnome optional gparted_1.2.0-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQFHBAEBCgAxFiEEJO4GrbVMYQCxZPumg69iNPbNdy0FAmAYFYQTHHBoaWxsQHRo
ZXN1c2lzLm5ldAAKCRCDr2I09s13LXM6CACMST3a0da39L2gVXiFOgyDjaT2bOql
muALfflI8X63NgoVU2W3+Z7/0nRgIGOs7lSaRJxpUALezcLVElLR660l8mM/VbHu
XQCZKhUHUixxIlMdD3idHBDlK1HJWcm2QejC4aimUBSaKNJnSXDX3eFPjQs5JOC1
cwpAIK+n8G8FqIHiFTmnBdvihe9sOy67LDZZo2A1alZyKzNSNShWtiw44cgLwpov
ZpMu7vZkQr/5zx8LHm0ZLk2/lE2+dDCEj2z18lP6AZIhhle1eTt94C/3j04VddHj
zjZh80aUseCTjbAN/F2p2p9xJccyjJSnfq21S+oOyymNhT0p/FEUKrIu
=bMc5
-----END PGP SIGNATURE-----

Ivo De Decker writes:

Woops... you're right.

Hi Maintainer

The release team no longer [1] considers popcon a criterion for
inclusion in the list of key packages [2].

This email is a courtesy reminder of this bug, and should prevent
instant auto-removal once the rule is changed in britney.

Regards
Graham


[1] http://meetbot.debian.net/debian-release/2021/debian-release.2021-01-27-19.07.html
[2] https://udd.debian.org/cgi-bin/key_packages.yaml.cgi

GParted 1.6.0, released 2024-02-26, includes this commit:
    Stop masking the root file system mount unit (!116)
https://gitlab.gnome.org/GNOME/gparted/-/commit/4dc683b26177bf97e23390c6439eecf04c8686cb

It addresses the issue of the -.mount unit being masked.

However GParted still masks other .mount units.  That is the subject of
referenced upstream bug which is not yet fixed.
https://gitlab.gnome.org/GNOME/gparted/-/issues/255

Thanks,
Mike Fleetwood (GParted Developer)