#953415 libsass: performance regression from v3.5.2 to v3.6.4

Package:
libsass
Source:
libsass
Submitter:
Dragos Jarca
Date:
2021-03-01 17:21:09 UTC
Severity:
important
Tags:
#953415#5
Date:
2020-03-09 09:37:07 UTC
From:
To:
Dear Maintainer,

When updating to 12.6.8.1 I have two problems:

1. Could not find gem 'deckar01-task_list (= 2.2.1)' in any of the gem
sources listed in your Gemfile.
solved by editing Gemfile:
gem 'deckar01-task_list', '2.3.1'


2. Top-level selectors may not contain the parent selector "&"

[5/5] Building fresh packages...
$ node ./scripts/frontend/postinstall.js
success Dependency postinstall check passed.
Done in 33.53s.
I, [2020-03-09T10:22:03.456949 #2195262]  INFO -- : Writing
/usr/share/gitlab/public/assets/emoji_sprites-6971486a811b8e0f3f4d35a546ad581196c3e9763237883df27970853d4adeb5.css
I, [2020-03-09T10:22:03.467003 #2195262]  INFO -- : Writing
/usr/share/gitlab/public/assets/emoji_sprites-6971486a811b8e0f3f4d35a546ad581196c3e9763237883df27970853d4adeb5.css.gz
I, [2020-03-09T10:22:04.360900 #2195262]  INFO -- : Writing
/usr/share/gitlab/public/assets/errors-5d74e774f61c743fb068f7aa706b4b34656aa68c0cd5818948f01d81b716b072.css
I, [2020-03-09T10:22:04.362359 #2195262]  INFO -- : Writing
/usr/share/gitlab/public/assets/errors-5d74e774f61c743fb068f7aa706b4b34656aa68c0cd5818948f01d81b716b072.css.gz
I, [2020-03-09T10:22:17.199709 #2195262]  INFO -- : Writing
/usr/share/gitlab/public/assets/auth_buttons/salesforce_64-3eb1feb32f86b99e2650dcf3bf280a4c74fc07aaad97c88d4435b697b31613ed.png
I, [2020-03-09T10:22:17.728510 #2195262]  INFO -- : Writing
/usr/share/gitlab/public/assets/cluster_app_logos/crossplane-9ceca67b2b9a8740daeacc45d783c2ba73b23b307a04688fcbafca5452b6795d.png
I, [2020-03-09T10:22:38.859234 #2195262]  INFO -- : Writing
/usr/share/gitlab/public/assets/favicon-blue-d8d16ee4d0d7e663e28aab8a282483671bfc0d00dffe4244944dd960620e2629.png
I, [2020-03-09T10:22:38.900424 #2195262]  INFO -- : Writing
/usr/share/gitlab/public/assets/favicon-f34ef73e6504fe12db99198e77bc12fb1b4b616b2b186f0e5b5bf3265c327fce.png
I, [2020-03-09T10:22:39.272530 #2195262]  INFO -- : Writing
/usr/share/gitlab/public/assets/none-scheme-preview-dbdbc404f98ec1239cd8f4861ab537a3675832adad096d9cfa67fd274987c602.png
I, [2020-03-09T10:22:41.478022 #2195262]  INFO -- : Writing
/usr/share/gitlab/public/assets/error_tracking/components/error_details-5e51d4ecbf7371053e0f23db7f16e27022bdc211d558ef2eb218fa47ffde477a.vue
I, [2020-03-09T10:29:57.745243 #2195262]  INFO -- : Writing
/usr/share/gitlab/public/assets/vue_merge_request_widget/components/states/mr_widget_rebase-ee896f4e5e1025eb3af5ec10abe30b4276ee024c2e1fff8e316cf2fb46768b12.vue
rake aborted!
SassC::SyntaxError: Error: Top-level selectors may not contain the
parent selector "&".
         on line 6:9 of node_modules/@gitlab/ui/src/scss/components.scss
         from line 13:9 of node_modules/@gitlab/ui/src/scss/gitlab_ui.scss
         from line 5:9 of app/assets/stylesheets/framework.scss
         from line 19:9 of app/assets/stylesheets/application.scss
 >>   &.gl-avatar-identicon-bg#{$i} {

    --^
/usr/share/gitlab/node_modules/@gitlab/ui/src/scss/../components/base/avatar/avatar.scss:82
/usr/share/rubygems-integration/all/gems/sassc-2.0.1/lib/sassc/engine.rb:49:in
`render'
Tasks: TOP => assets:precompile
(See full trace by running task with --trace)
dpkg: error processing package gitlab (--configure):
  installed gitlab package post-installation script subprocess returned
error exit status 1
Errors were encountered while processing:
  gitlab
E: Sub-process /usr/bin/dpkg returned an error code (1)

Please help me to solve upgrade.

And a proposal: use 12.8 in experimental and whatever version you want
in unstable.

#953415#10
Date:
2020-03-14 16:23:11 UTC
From:
To:
Control: forwarded -1
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/27267
gem

I think this was introduced by libsass/ruby-sassc updates.
6971486a811b8e0f3f4d35a546ad581196c3e9763237883df27970853d4adeb5.css
6971486a811b8e0f3f4d35a546ad581196c3e9763237883df27970853d4adeb5.css.gz
5d74e774f61c743fb068f7aa706b4b34656aa68c0cd5818948f01d81b716b072.css
5d74e774f61c743fb068f7aa706b4b34656aa68c0cd5818948f01d81b716b072.css.gz
3eb1feb32f86b99e2650dcf3bf280a4c74fc07aaad97c88d4435b697b31613ed.png
9ceca67b2b9a8740daeacc45d783c2ba73b23b307a04688fcbafca5452b6795d.png
d8d16ee4d0d7e663e28aab8a282483671bfc0d00dffe4244944dd960620e2629.png
f34ef73e6504fe12db99198e77bc12fb1b4b616b2b186f0e5b5bf3265c327fce.png
dbdbc404f98ec1239cd8f4861ab537a3675832adad096d9cfa67fd274987c602.png
/usr/share/gitlab/public/assets/error_tracking/components/error_details
-5e51d4ecbf7371053e0f23db7f16e27022bdc211d558ef2eb218fa47ffde477a.vue
/usr/share/gitlab/public/assets/vue_merge_request_widget/components/sta
tes/mr_widget_rebase-
ee896f4e5e1025eb3af5ec10abe30b4276ee024c2e1fff8e316cf2fb46768b12.vue
css
.scss
/avatar/avatar.scss:82
2.0.1/lib/sassc/engine.rb:49:in
returned

#953415#15
Date:
2020-03-14 17:41:34 UTC
From:
To:
Just confirmed, downgrading libsass to 3.6.1 fixed the issue

Get it from
http://snapshot.debian.org/package/libsass/3.6.1-1/

#953415#20
Date:
2020-03-15 09:44:20 UTC
From:
To:
Thx Praaven!

Downgrading libsaas1 and dev to 3.6.1-1 solved problem 2.

2. Top-level selectors may not contain the parent selector "&"

#953415#31
Date:
2020-08-26 09:49:09 UTC
From:
To:
Control: reassign -1 libsass
Control: affects -1 gitlab

Seems like a regression in libsass.

#953415#42
Date:
2020-08-26 14:24:34 UTC
From:
To:
control: severity -1 minor
control: tags -1 moreinfo

Quoting Debian Bug Tracking System (2020-08-26 11:51:05)

When reassigning to another package, then please re-examine severity,
and clarify the issue in the context of the package reassigned to -
including retitle of the issue as needed.

I fail to recognize that "Problem installing 12.8.8-6" is an issue of
libsass at all, I do not understand what issue is "Top-level selectors
may not contain the parent selector "&"", and I see references only to
upstream of _gitlab_ but none for the upstream of _libsass_.



 - Jonas

#953415#51
Date:
2020-09-05 08:13:38 UTC
From:
To:
Control: forwarded -1 https://github.com/sass/libsass/issues/3125
Control: retitle -1 regression in libsass
Control: severity -1 serious

Retitled now. It completely breaks gitlab installation caused by a memory leak (libsass just hangs) and hence serious.

The gitlab upstream issue linked has links to libsass upstream issue. Now changed forwarded entry to libsass issue.

#953415#62
Date:
2020-09-05 14:38:45 UTC
From:
To:
Quoting Pirate Praveen (2020-09-05 10:13:38)

Thanks.  Please note that package name is listed first with colon.

I have now updated tite, with a bit more detail than just "regression".

Lowered severity: libsass has usecases where this regression is not
release critical.


 - Jonas

#953415#71
Date:
2020-09-05 14:50:45 UTC
From:
To:
autopkgtest regression of a reverse dependency (ie, the tests pass with
the previous version) is considered a blocker for testing migration,
which means it is release critical.

Since gitlab autopkgtest was already failing for other reasons, this
was not found by britney. Since gitlab is not in testing (as one
potential solution in such cases would be removing gitlab from testing
to unblock the migration), I will not push on this and leave the
severity at important.

#953415#76
Date:
2020-09-05 15:25:35 UTC
From:
To:
Quoting Pirate Praveen (2020-09-05 16:50:45)

Apples and oranges...:

An autopkgtest failure is a regression that is treated as release
critical by default, yes.

This is not an autopkgtest regression.

I do not reconize _this_ issue as a release critical regression.


 - Jonas

#953415#81
Date:
2020-09-05 16:39:16 UTC
From:
To:
gitlab installation works with lower versions of ruby-grpc,
ruby-google-protobuf and libsass1. Just because grpc also caused a
regression does not mean libsass did not cause it. Both caused
regressions.

Alright. So I guess you just refuse to accept arguments just because
you are the maintainer here. I thought we are supposed to be
collaborating together with debian policy as a baseline. May be I'm
mistaken.

#953415#86
Date:
2020-09-05 19:14:35 UTC
From:
To:
Quoting Pirate Praveen (2020-09-05 18:39:16)

No, I just don't equal "regression" and "release-critical regression".

do you?


 - Jonas

#953415#91
Date:
2020-12-09 18:08:31 UTC
From:
To:
Hi

Some news about this bug?

There are a lot of packages that depend of libsass and I cannot install
updates because use libsass 3.6.1 because of gitlab workaround.

Now gitlab work with newer version of libsass?

#953415#96
Date:
2021-02-27 17:04:33 UTC
From:
To:
On Wed, 9 Dec 2020 20:08:31 +0200 Dragos Jarca  <dragos.jarca@dynamicpuzzle.ro> wrote:
 > Hi
 >
 > Some news about this bug?
 >
 > There are a lot of packages that depend of libsass and I cannot
install
 > updates because use libsass 3.6.1 because of gitlab workaround.
 >
 > Now gitlab work with newer version of libsass?

It is forwarded upstream, but no response.

https://github.com/sass/libsass/issues/3125