#954662 obantoo: Obantoo includes an outdated BLZ.txt

#954662#5
Date:
2020-03-22 12:49:06 UTC
From:
To:
The current version of BLZ.txt in the package dates from 2015, which
means that checks for new BLZs and IBANs based on them will fail (e.g.
59020400). While the Deutsche Bundesbank makes available updated BLZ.txt
files for free on their website, obantoo uses the extended version
("erweiterte Bankleitzahlendatei"), which is only available with an
account on their Extranet[1]. I have applied for an account, but have
not yet received an answer. However, a recent version of BLZ.txt has
been added by the Hibiscus author and can be extracted from [2].

I prepared a patch based on [2], but the resulting diff is 6 MB in size
- which is suboptimal. I do not have a really good proposal on how to
move forward here, but given that an updated BLZ.txt is published every
quarter, it seems suboptimal to put it into the JAR file:
  1) This makes it unneccessarily difficult to find the file and replace
  it with a local version.
  2) It requires a new release of the software when it reality there
  were no code changes and only a data update.

[1] https://www.bundesbank.de/de/aufgaben/unbarer-zahlungsverkehr/serviceangebot/bankleitzahlen/bankleitzahlen-602638
[2] https://github.com/willuhn/hibiscus/raw/master/lib/obantoo-bin-2.1.12.jar

Kind regards,
Thomas

#954662#10
Date:
2020-03-28 04:19:05 UTC
From:
To:
Hi Thomas,

It sounds like you are proposing creating a separate "obantoo-data"
package that is updated regularly.

Fortunately there is only place in the source code that references the
data file [3] (and then a few further lines down for the CSV file for
Austria [4]), and it wouldn't be too difficult to write a patch to
source these files from the file system.  If we decide to go this path,
we'll want to exclude the data files from the obantoo sources when we
repack the source archive. (Otherwise we would end up with a large diff
to represent the deletions.)

Does that sound like a reasonable solution?  I can help with patch for
obantoo if that's helpful.

Cheers,
tony

[3] https://salsa.debian.org/java-team/obantoo/-/blob/master/src/de/jost_net/OBanToo/SEPA/BankenDaten/Banken.java#L30
[4] https://salsa.debian.org/java-team/obantoo/-/blob/master/src/de/jost_net/OBanToo/SEPA/BankenDaten/Banken.java#L47

#954662#15
Date:
2020-03-29 17:56:37 UTC
From:
To:
Hi Thomas,

* Thomas Weber <tweber@debian.org> [2020-03-22 13:49]:

Thanks for bringing up this issue! As far as I tested this only means
that the BLZ is not recognized by Hibiscus, or is it blocking the
payment?

Cheers Jochen

#954662#20
Date:
2020-03-29 18:01:18 UTC
From:
To:
Hi Tony,

* tony mancill <tmancill@debian.org> [2020-03-27 21:19]:

I would be happy to accept such a patch into the obantoo package.
Would one of you be willing to come up with a obantoo-data package?

Cheers Jochen

#954662#25
Date:
2022-03-14 16:47:41 UTC
From:
To:
Dear Maintainer,

This problem still exists.
I cannot transfer money to an N26 bank account, because jameica complains that
the bank does not exist:

#954662#30
Date:
2022-12-18 12:49:59 UTC
From:
To:
Hi Christian,

sorry for the late reply.

* Christian Weiske <cweiske+bugs.debian.org@cweiske.de> [2022-03-14 17:47]:

Thanks for the report, I've just uploaded version 2.10.9+dfsg-2 that
should work around this problem (again).

Cheers Jochen

#954662#35
Date:
2023-01-15 20:19:39 UTC
From:
To:
Is this problem resolved?  Is it okay to mark this bug as closed?
#954662#40
Date:
2023-01-15 20:27:05 UTC
From:
To:
Hi Tony,

* tony mancill <tmancill@debian.org> [2023-01-15 12:19]:

I think the real solution here would be a package with up to date data
(or some online service to check against, maybe). The current workaround
is just there to avoid the software failing on a valid use case. Thus I
would leave it open.

Are you interested in working on this?

Cheers Jochen