#956205 libsass: performance regression from v3.5.2 to v3.6.4

Package:
libsass
Source:
libsass
Submitter:
David L
Date:
2021-03-01 17:21:10 UTC
Severity:
important
Tags:
#956205#5
Date:
2020-04-08 10:29:36 UTC
From:
To:
Hi,

Gitlab 12.8.8 installation fails.

Log:

Bundle complete! 198 Gemfile dependencies, 362 gems now installed.
Gems in the groups development and test were not installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
Running final rake tasks and tweaks...
gitlab_production database is not empty, skipping gitlab setup

Precompiling assets...
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
Attention: used pure ruby version of MurmurHash3
/usr/share/gitlab/lib/gitlab.rb:38: warning: already initialized constant Gitlab::COM_URL
/usr/share/gitlab/lib/gitlab.rb:38: warning: previous definition of COM_URL was here
/usr/share/gitlab/lib/gitlab.rb:39: warning: already initialized constant Gitlab::APP_DIRS_PATTERN
/usr/share/gitlab/lib/gitlab.rb:39: warning: previous definition of APP_DIRS_PATTERN was here
/usr/share/gitlab/lib/gitlab.rb:40: warning: already initialized constant Gitlab::SUBDOMAIN_REGEX
/usr/share/gitlab/lib/gitlab.rb:40: warning: previous definition of SUBDOMAIN_REGEX was here
/usr/share/gitlab/lib/gitlab.rb:41: warning: already initialized constant Gitlab::VERSION
/usr/share/gitlab/lib/gitlab.rb:41: warning: previous definition of VERSION was here
/usr/share/gitlab/lib/gitlab.rb:42: warning: already initialized constant Gitlab::INSTALLATION_TYPE
/usr/share/gitlab/lib/gitlab.rb:42: warning: previous definition of INSTALLATION_TYPE was here
/usr/share/gitlab/lib/gitlab.rb:43: warning: already initialized constant Gitlab::HTTP_PROXY_ENV_VARS
/usr/share/gitlab/lib/gitlab.rb:43: warning: previous definition of HTTP_PROXY_ENV_VARS was here
yarn install v1.22.4
[1/4] Resolving packages...
success Already up-to-date.
$ node ./scripts/frontend/postinstall.js
success Dependency postinstall check passed.
Done in 1.45s.
rake aborted!
SassC::SyntaxError: Error: Top-level selectors may not contain the parent selector "&".
        on line 6:9 of node_modules/@gitlab/ui/src/scss/components.scss
        from line 13:9 of node_modules/@gitlab/ui/src/scss/gitlab_ui.scss
        from line 5:9 of app/assets/stylesheets/framework.scss
        from line 19:9 of app/assets/stylesheets/application.scss

#956205#10
Date:
2020-04-08 14:38:34 UTC
From:
To:
Control: merge 953415 -1

It is already known and work around documented in https://wiki.debian.org/gitlab (it is a good idea to check that page for known issues). Upstream sassc gem is still using an older version of libsass and sassc is failing to build on CentOS 6, so it is currently not easy to reproduce for gitlab upstream.

#956205#19
Date:
2020-04-08 19:24:03 UTC
From:
To:
Control: forwarded -1 https://gitlab.com/gitlab-org/gitlab/-/merge_requests/29187

I have opened MR upstream to reproduce the issue https://gitlab.com/gitlab-org/gitlab/-/merge_requests/29187 if they provide a patch, we can include it. For now, downgrade libsass.