#959665 git-buildpackage: please put a full stop after "New upstrem version X."

Package:
git-buildpackage
Source:
git-buildpackage
Submitter:
Mattia Rizzolo
Date:
2023-03-03 10:27:05 UTC
Severity:
wishlist
#959665#3
Date:
2020-05-03 14:52:24 UTC
From:
To:
Hi,

my OCD is telling me that a changelog should be properly formatted, with
full stops and all.

Please consider changing the default from "New upstream version X" to
"New upstream version X.".
Attached an untested patch to do so.

TIA!
#959665#8
Date:
2020-05-03 17:38:11 UTC
From:
To:
Hi,

But it's not a full sentence so why should it stop with a full stop?
 -- Guido
#959665#11
Date:
2020-05-04 09:37:53 UTC
From:
To:
Hmm, indeed it's not a full sentence.  It's what I think is called a
"verbless clause", but that doesn't really make it any less "complete"
than a full sentence :)

Not to mention that changelog lines are usually concise anyway, so I
really consider "New upstream version 1.2.3." complete and done by
itself.
#959665#14
Date:
2020-05-04 10:08:04 UTC
From:
To:
I prefer my debian/changelog entries to end with a dot, please allow
for that.

Christoph
#959665#19
Date:
2020-05-11 09:13:20 UTC
From:
To:
Hi,

It does seem that having a full stop at the end of debian/changelogs is
conventional. However, this is already easy to configure locally. I had
this in my debian/gbp.conf for a long time:

  [import-orig]
  import-msg = New upstream release %(version)s.

I've since removed the dot again, since for *git* commit messages, it is
conventional to *not* have a full stop at the end of the first line and
I kept forgetting to add it for my Debian packages, so now my changelogs
also omit the full stop.

Also, it seems that Debian policy does not mention the full stop at all:
https://www.debian.org/doc/debian-policy/ch-source.html#debian-changelog-debian-changelog

Anyway, this is already easy to configure, so I wonder if this would be
worth changing?

Gr.

Matthijs
#959665#24
Date:
2020-05-11 10:08:30 UTC
From:
To:
Hi,

That's what i'm unsure about too and the reason i was asking for the
pattern behind this. I'm leaning more to leave things as is for the
moment too - so thanks for your input!
Cheers,
 -- Guido
#959665#29
Date:
2023-03-03 10:24:56 UTC
From:
To:
Hi,
commit body so the git commit message goes without a dot while the
changelog entry gets a dot in multiline messages (See
terminate_first_line_if_needed) if the body starts with a capital letter.

The only thing needed would be to make it act on one line messages at
all - either by adding yet another option or by reaching consensus.
Policy section 4.4. Debian changelog: "debian/changelog" does not
make any recommendations along these lines.

Cheers,
 -- Guido