#970673 nspr: Some tests are not run due to a bug in debian/rules

Package:
src:nspr
Source:
nspr
Submitter:
Date:
2021-08-11 14:33:03 UTC
Severity:
important
Tags:
#970673#5
Date:
2020-09-21 09:07:34 UTC
From:
To:
Hello,

In debian/rules the runtests.sh script is not run properly. The line

cd nspr/pr/tests && grep -v
'^\(fdcach\|gethost\|getproto\|nblayer\|peek\|socket\|vercheck\)$$'
./runtests.sh | sh - $(CURDIR)/nspr/dist

needs to change to

cd nspr/pr/tests && grep -v
'^\(fdcach\|gethost\|getproto\|nblayer\|peek\|socket\|vercheck\)' ./runtests.sh
| sh -s - $(CURDIR)/nspr/dist

Note that only fdcach and peek tests are activated in runtests.sh, all other
tests are already commented out in that file, so the above line can be
significantly reduced.

Attached is a patch to fix this together with the tests for GNU/Hurd, reported
in #970659: debian_rules.diff.

Thanks!
#970673#14
Date:
2021-08-11 14:31:05 UTC
From:
To:
On Mon, 21 Sep 2020 11:07:34 +0200 Svante Signell  <svante.signell@gmail.com> wrote:

 > Hello,
 >
 > In debian/rules the runtests.sh script is not run properly. The line
 >
 > cd nspr/pr/tests && grep -v
 > '^\(fdcach\|gethost\|getproto\|nblayer\|peek\|socket\|vercheck\)$$'
 > ./runtests.sh | sh - $(CURDIR)/nspr/dist
 >
 > needs to change to
 >
 > cd nspr/pr/tests && grep -v
 > '^\(fdcach\|gethost\|getproto\|nblayer\|peek\|socket\|vercheck\)'
./runtests.sh
 > | sh -s - $(CURDIR)/nspr/dist
 >
 > Note that only fdcach and peek tests are activated in runtests.sh,
all other
 > tests are already commented out in that file, so the above line can be
 > significantly reduced.
 >
 > Attached is a patch to fix this together with the tests for GNU/Hurd,
reported
 > in #970659: debian_rules.diff.
 >

Can this patch (or similar) be applied?

This is also fixing the FTBFS on kfreebsd