Hello, I see you build an embedded xxhash.c/xxhash.h version of the xxhash library already in Debian.

I tried to use the system version, but some pre-processor directives such as XXH_NAMESPACE=ZSTD_ are tricking my
efforts in crafting a patch, resulting into some undefined libraries when linking.

Please consider asking upstream to detect and support (if possible) a system library, or add it to the list
of embedded libraries in Debian

G.

Hi, I believe that using the system library is not possible, as libzstd uses
some private symbols of xxhash. See:
https://github.com/facebook/zstd/pull/2746/commits/9748608aeb6a68ca622268eb8ba07e9003079e8f

Also, it seems that the embedded xxhash lib is slightly modified, see
https://github.com/facebook/zstd/pull/2914 ("with minor modifications directly
embedded in source"). This would make things even harder, and could result in
subtle issues.


- -- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.16.0-5-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-----BEGIN PGP SIGNATURE-----

iIoEARYIADIWIQSlw/BqXszDGx3GlQz/yQfijUdG7QUCYkiwbBQcYW5kcmVhQHBh
cHBhY29kYS5pdAAKCRD/yQfijUdG7eUZAP0R3McD/RW/URyV2KhAQcanM81C2IWd
k6RGzpLhL/WvKQEAxf0aaREs9du/k9Xg32D3um3fXDKC4eWLXj2eL3vHiQ4=
=NDe1
-----END PGP SIGNATURE-----