#974833 iw: output of 'mpath dump' is wrongly formatted

Package:
iw
Source:
iw
Description:
tool for configuring Linux wireless devices
Submitter:
José Miguel Gonçalves
Date:
2022-07-12 22:54:06 UTC
Severity:
minor
Tags:
#974833#5
Date:
2020-11-15 10:30:34 UTC
From:
To:
Dear Maintainer,

Using iw to display a list of Mesh paths leads to a wrongly formatted output:

$ sudo iw dev mesh0 mpath dump
DEST ADDR         NEXT HOP          IFACE	SN	METRIC	QLEN	EXPTIME		DTIM	DRET	FLAGS
64:69:4e:XX:XX:XX 64:69:4e:XX:XX:XX mesh0	8885	57	0	0	100	0	0x14
84:eb:18:XX:XX:XX 84:eb:18:XX:XX:XX mesh0	44751	65	0	2292	100	0	0x15
f0:45:da:XX:XX:XX f0:45:da:XX:XX:XX mesh0	51710	66	0	1972	100	0	0x15
0c:1c:57:XX:XX:XX 0c:1c:57:XX:XX:XX mesh0	41711	66	0	2592	100	0	0x15

As you can see form the above iw command output, the table header, between "EXPTIME" and "DTIM" columns, has an extra tab.

Best regards,
José Gonçalves
#974833#10
Date:
2020-11-18 11:14:37 UTC
From:
To:
José Miguel Gonçalves wrote on 15/11/2020:

Hi José, thanks for this bug report.

Could you perhaps test how the version of 'iw' currently in testing behaves?

Cheers,

Paride
#974833#15
Date:
2020-11-18 14:00:44 UTC
From:
To:
For sure. This is how it looks with testing:

$ iw --version
iw version 5.9
$ sudo iw dev mesh0 mpath dump
DEST ADDR         NEXT HOP          IFACE       SN METRIC  QLEN   
EXPTIME         DTIM    DRET    FLAGS HOP_COUNT    PATH_CHANGE
64:69:4e:XX:XX:XX 64:69:4e:XX:XX:XX mesh0       0 58      0      
1988    0       0       0x11
f0:45:da:XX:XX:XX f0:45:da:XX:XX:XX mesh0       112012 57      0      
0       0       0       0x14
86:eb:18:XX:XX:XX 86:eb:18:XX:XX:XX mesh0       30129 66      0      
2072    0       0       0x15
64:69:4e:XX:XX:XX 86:eb:18:XX:XX:XX mesh0       269722 128     0      
2072    100     0       0x15

So, apart from two extra columns in the output, the look is the same,
i.e., it still has an extra tab between "EXPTIME" and "DTIM" header columns.

Best regards,
José Gonçalves
#974833#20
Date:
2021-04-14 16:52:25 UTC
From:
To:
Will this be fixed in bullseye?

Best regards,
José Gonçalves
#974833#25
Date:
2021-04-15 10:45:39 UTC
From:
To:
Hi,

The following patch solves this issue for me:

--- a/mpath.c
+++ b/mpath.c
@@ -226,7 +226,7 @@
                   enum id_input id)
  {
      printf("DEST ADDR         NEXT HOP IFACE\tSN\tMETRIC\tQLEN\t"
- "EXPTIME\t\tDTIM\tDRET\tFLAGS\tHOP_COUNT\tPATH_CHANGE\n");
+ "EXPTIME\tDTIM\tDRET\tFLAGS\tHOP_COUNT\tPATH_CHANGE\n");
      register_handler(print_mpath_handler, NULL);
      return 0;
  }


Best regards,
José Gonçalves
#974833#30
Date:
2021-11-01 14:28:02 UTC
From:
To:
José Miguel Gonçalves wrote on 15/04/2021:
[...]

Hi and thanks for submitting a patch. While the patch is straightforward
enough, the severity of the bug is also really low, so in evaluating the
effort/reward ratio for patching iw in Debian I kind of get in a 0/0
indeterminate form. :-)

My general package maintenance philosophy on patches is "don't diverge
from upstream unless necessary". In other words I think the patch
belongs to upstream iw, and I don't see why it shouldn't get accepted
there. Once in upstream git I'll happily cherry-pick it in the Debian
package, only to drop it with the first release that ships it.

Fixing this upstream will also benefit all the iw users, and not only
Debian and derivatives.

Would you consider submitting your patch upstream?
Documentation on how to do it is available at [1].

Thanks!

Paride

[1]
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#974833#35
Date:
2022-04-23 16:15:11 UTC
From:
To:
I've made an attempt, hope that's alright. And hopefully I did it correctly.
#974833#54
Date:
2022-06-09 08:52:04 UTC
From:
To:
And it is included in the v5.19 release, so when the iw package gets updated,
this bug should be closed with it.
#974833#59
Date:
2022-07-12 22:48:59 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
iw, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 974833@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Paride Legovini <paride@debian.org> (supplier of updated iw package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Tue, 12 Jul 2022 22:30:15 +0000
Source: iw
Architecture: source
Version: 5.19-1
Distribution: unstable
Urgency: medium
Maintainer: Paride Legovini <paride@debian.org>
Changed-By: Paride Legovini <paride@debian.org>
Closes: 974833
Changes:
 iw (5.19-1) unstable; urgency=medium
 .
   [ Paride Legovini ]
   * New upstream version 5.19.
     (Closes: #974833, thanks to Diederik de Haas)
   * d/control: bump Standards-Version to 4.6.1, no changes needed
   * d/control: fix spelling error in description
 .
   [ Ben Hutchings ]
   * d/salsa-ci.yml: Add CI configuration for Salsa
   * d/rules: Enable verbose build unless the "terse" build option is used
Checksums-Sha1:
 5065e38a34758a4b81eb5d90d435820ac7633ca3 1510 iw_5.19-1.dsc
 1c32766240c319698542d677ac1ba67bee5b3001 152044 iw_5.19.orig.tar.xz
 870f471b2ac084c80c1cc0bc4db660cecfb5f551 34816 iw_5.19-1.debian.tar.xz
 924f9a0f3f12adbff239bfa75a611a04d7b72117 5933 iw_5.19-1_amd64.buildinfo
Checksums-Sha256:
 6254b8b1dfbf0fd217b772a9eb60800b04ac13b5dcd7cc0f0b083661ce621823 1510 iw_5.19-1.dsc
 f167bbe947dd53bb9ebc0c1dcef5db6ad73ac1d6084f2c6f9376c5c360cc4d4e 152044 iw_5.19.orig.tar.xz
 b7b129bc93a12a492cdcea5b4d858830cfd30237d1f7855532ee4b27e53831aa 34816 iw_5.19-1.debian.tar.xz
 2190d1b9aa331869bfd71b14986c3d5f24176ee39db2672b8df492213d0afd8f 5933 iw_5.19-1_amd64.buildinfo
Files:
 4aa0f4257b5587dc8e6b1648f681c53b 1510 net optional iw_5.19-1.dsc
 fd17ca2dd5f160a5d9e5fd3f8a69f416 152044 net optional iw_5.19.orig.tar.xz
 7662896af3f2b8bc13958870adcf28c4 34816 net optional iw_5.19-1.debian.tar.xz
 50e9b3c4949954aa731c5fe74c89a4a4 5933 net optional iw_5.19-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQFGBAEBCgAwFiEEVhrVhe7XZpIbqN2W1lhhiD4BTbkFAmLN9q0SHHBhcmlkZUBk
ZWJpYW4ub3JnAAoJENZYYYg+AU25yKcH/j/5Uma6Z7sFggCIY+z3iiOUOqDS8A9h
7LWiMriJWbJpD/cUMrLUvzp/CcEoEUeiiju4P4AH1r9Ph0iIcM6uvOwGXSccVdNW
JJX1YW4R2aoxNVrU4gWJKsDm2ngcFjAQej4rz45G4oam+xF1mQKDpapq0bP2/jdu
A6cXo9ljGvr4NIrIUp62dtT5gv2w4I6Liubpotg8AxTvBw+S5NCFki5ellVse6pR
0fRP3t2HRB2ZZqA/3FJY2Gw7lOS+s84xBtK1NdCyPEpMOMl5QXoBHXkDcEmGgwyj
KhyaUue3wKvd/tWKtMp4LVicjejSxxcmiyb9m0OFlKbaTI0TiSlpYqY=
=MP8L
-----END PGP SIGNATURE-----