#975055 bsdiff: make bspatch a little less memory hungry

Package:
bsdiff
Source:
bsdiff
Description:
generate/apply a patch between two binary files
Submitter:
Vincent Galceran
Date:
2022-01-13 17:03:05 UTC
Severity:
normal
Tags:
#975055#5
Date:
2020-11-18 12:52:26 UTC
From:
To:
Dear Maintainer,

This is the same problem as bug 632585 for bspatch instead of bsdiff.
bspatch should be able to run on systems with less available memory with this patch.

The patch in attachment includes:
- bspatch.c: we use mmap instead of malloc and read for old file in bspatch
- bspatch.c: we use mmap instead of malloc and write for new file in bspatch
- Makefile: gcc now requires to have libs at the end of command line when linking

Regards,

#975055#10
Date:
2020-11-18 13:18:05 UTC
From:
To:
 Dear Maintainer,

Please find another version of the patch :
- in previous patch I added a variable but it was unused. So I remove it
- I added -Wall in Makefile
- I initialize a potentially uninitialized variable in bsdiff

Regards,


    Le mercredi 18 novembre 2020 à 13:54:05 UTC+1, Debian Bug Tracking System <owner@bugs.debian.org> a écrit :

 Thank you for filing a new Bug report with Debian.

You can follow progress on this Bug here: 975055: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=975055.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  vincent_galceran@yahoo.com
(after having been given a Bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 Jari Aalto <jari.aalto@cante.net>

If you wish to submit further information on this problem, please
send it to 975055@bugs.debian.org.

Please do not send mail to owner@bugs.debian.org unless you wish
to report a problem with the Bug-tracking system.

#975055#15
Date:
2022-01-11 09:51:55 UTC
From:
To:
Hi,
Here is the patch for 4.3-22.
Regards,

#975055#22
Date:
2022-01-12 05:43:28 UTC
From:
To:
Hello Vincent,

Thank you for the updated patch.  I intend to add some autopkgtests to
bsdiff and then will apply the patch and upload.

Cheers,
tony

#975055#27
Date:
2022-01-13 16:59:36 UTC
From:
To:
Hi Vincent,

The upload of 4.3-23 updates the packaging and adds an autopkgtest.  It
doesn't include any changes to the sources, so you don't need to rework
the patch.

However, I'd like to ask whether you have reached out to upstream
regarding the mmap() improvement.  It would be preferable to get this
folded into the upstream release.  That makes it easier for us to assess
CVEs, etc.

Would you be willing to initiate a conversation with the upstream author
regarding the patch?

Thanks,
tony