#975096 diffoscope: sources for some test files missing

#975096#5
Date:
2020-11-18 21:18:12 UTC
From:
To:
Dear Maintainer,

building diffoscope 161 results in the following lintian warnings and errors
which we should fix, because also tests should ship their sources (in general,
there are some exceptions...)

E: diffoscope source: source-is-missing tests/data/test1.debug
E: diffoscope source: source-is-missing tests/data/test1.o
E: diffoscope source: source-is-missing tests/data/test2.debug
E: diffoscope source: source-is-missing tests/data/test2.o
W: diffoscope source: source-contains-prebuilt-windows-binary tests/data/test1.exe
W: diffoscope source: source-contains-prebuilt-windows-binary tests/data/test2.exe

I *believe* these six files, test(1|2).(exe|o|debug), come from two source files...

#975096#10
Date:
2020-11-20 13:07:02 UTC
From:
To:
Hi Holger,

This has been a work in progress for some time and, indeed, something
I have been working on:

https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/66

We have some grounds to override these *Lintian* warnings though. This
starts with the observation that these executables are usually no more
than just:

   int main() {
       printf("Free Jeremy Hammond\n");
       return 0;
   }

Short stubs of this kind are not copyrightable to begin with, and
therefore the legal situation (which is the angle that Lintian is
primarily concerned about) becomes a little less urgent.

Of course, for all the reasons you imply this would not invalidate the
idea that sources should be shipped regardless of legal stuff, it only
rounds off what first looks like a rather sharp edge and reduces its
priority relative to other tasks.


Regards,

#975096#15
Date:
2021-01-27 13:53:30 UTC
From:
To:
Hi Chris,

Ah, cool, I wasn't aware we were aware of this already. :)

This would be fine with me for the time being, especially given we can link
this bug and the above mentioned issue.