#984624 regexp.c: cast an int to size_t in a comparison

Package:
src:nn
Source:
nn
Submitter:
Bjarni Ingi Gislason
Date:
2021-03-05 23:09:03 UTC
Severity:
normal
Tags:
#984624#5
Date:
2021-03-05 23:07:36 UTC
From:
To:
Dear Maintainer,

regexp.c:275:52: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [-Wsign-compare]
  275 |   if (OP(scan) == EXACTLY && strlen(OPERAND(scan)) >= len) {
      |                                                    ^~

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 regexp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/regexp.c b/regexp.c
index 0a08534..316743e 100644
--- a/regexp.c
+++ b/regexp.c
@@ -272,7 +272,8 @@ regcomp(char *exp)
 	    longest = NULL;
 	    len = 0;
 	    for (; scan != NULL; scan = regnext(scan))
-		if (OP(scan) == EXACTLY && strlen(OPERAND(scan)) >= len) {
+		if (OP(scan) == EXACTLY && strlen(OPERAND(scan))
+		    >= (size_t) len) {
 		    longest = OPERAND(scan);
 		    len = strlen(OPERAND(scan));
 		}