#984634 menu.c: Fix errors

Package:
src:nn
Source:
nn
Submitter:
Bjarni Ingi Gislason
Date:
2021-03-06 03:30:03 UTC
Severity:
normal
Tags:
#984634#5
Date:
2021-03-06 03:27:25 UTC
From:
To:
Dear Maintainer,

  In case constructs:

  Use "break" as the last command in a case.

  Use /* FALLTHROUGH */, not a "goto default;" which does not function.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 menu.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/menu.c b/menu.c
index 6ddb96f..90462c4 100644
--- a/menu.c
+++ b/menu.c
@@ -1485,10 +1485,8 @@ new_state:

 		case AC_REENTER_GROUP:
 		    menu_return(ME_REENTER_GROUP);
- /* Previous command returns or "goto", but the compiler can't know that,
-so "break" is used to tell that */
-		    break; /* avoid a "fallthrough" warning */
 	    }
+	    break; /* avoid a warning */
 	    /* XXX: bug? fall */

 	case K_QUIT:
@@ -2412,8 +2410,9 @@ do_auto_read:
 		    firsta = nexta;
 		goto redraw;
 	    }
-	    goto default; /* Uncertain code, avoid a warning */
+	    /* FALLTHROUGH */ /* Avoids a warning */
 	    /* XXX: fall? */
+
 	case MC_NEXTGROUP:
 	    menu_cmd = ME_NEXT;
 	    break;