#984715 kill.c: cast a "long" to "size_t" for a comparison

Package:
src:nn
Source:
nn
Submitter:
Bjarni Ingi Gislason
Date:
2021-03-07 16:18:04 UTC
Severity:
normal
Tags:
#984715#5
Date:
2021-03-07 16:14:42 UTC
From:
To:
Dear Maintainer,

  "fwrite()" returns a type "size_t", but "len" and "ckh_pattern_size"
are of type "long" (comparison).

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 kill.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kill.c b/kill.c
index 58877de..083ea65 100644
--- a/kill.c
+++ b/kill.c
@@ -682,7 +682,7 @@ next_entry:
 		entry.ck_group = (long) ftell(patternf);
 		cp++;
 		len = strlen(cp) + 1;
-		if (fwrite(cp, sizeof(char), len, patternf) != len)
+		if (fwrite(cp, sizeof(char), len, patternf) != (size_t) len)
 		    goto err3;
 		flag |= GROUP_REGEXP | GROUP_REGEXP_HDR;
 	    } else {
@@ -768,7 +768,7 @@ next_entry:
 	    if (fwrite((char *) &entry, sizeof(entry), 1, compf) != 1)
 		goto err3;

-	    if (fwrite(np, sizeof(char), len, patternf) != len)
+	    if (fwrite(np, sizeof(char), len, patternf) != (size_t) len)
 		goto err3;

 	    header.ckh_entries++;
@@ -900,7 +900,7 @@ again:
 	kill_patterns = newstr(header.ckh_pattern_size);
 	fseek(killf, header.ckh_entries * sizeof(entry), 1);
 	if (fread(kill_patterns, sizeof(char), (int) header.ckh_pattern_size, killf)
-	    != header.ckh_pattern_size)
+	    != (size_t) header.ckh_pattern_size)
 	    goto err;
     } else
 	kill_patterns = newstr(1);