#986228 nntp.c: close the file "resolv" to avoid leaking

Package:
src:nn
Source:
nn
Submitter:
Bjarni Ingi Gislason
Date:
2021-04-01 03:03:04 UTC
Severity:
normal
Tags:
#986228#5
Date:
2021-04-01 02:59:11 UTC
From:
To:
Dear Maintainer,

  The compiler option "-fanalyzer" shows:

nntp.c: In function 'set_domain':
nntp.c:957:1: warning: leak of FILE 'resolv' [CWE-775] [-Wanalyzer-file-leak]
  957 | }
      | ^
...

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 nntp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/nntp.c b/nntp.c
index a320df4..66064b6 100644
--- a/nntp.c
+++ b/nntp.c
@@ -942,6 +942,7 @@ set_domain(void)
 		    break;
 		}
 	    }
+	    fclose(resolv);
 	}
 	if (domain[0] == '\0')
 	    nn_exitmsg(1, "hostname=%s, You need a fully qualified domain name", host_name);