#986261 folder.c: add code for the case "cur_grp = NULL"

Package:
src:nn
Source:
nn
Submitter:
Bjarni Ingi Gislason
Date:
2021-04-02 00:57:03 UTC
Severity:
normal
Tags:
#986261#5
Date:
2021-04-02 00:52:25 UTC
From:
To:
Dear Maintainer,

  The compiler option "-fanalyzer" shows:

folder.c: In function 'expand_file_name':
folder.c:177:17: warning: use of NULL 'cur_grp' where non-null expected [CWE-690] [-Wanalyzer-null-argument]
  177 |       if ((cp = strrchr(cur_grp, '.')))
      |                 ^~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 folder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/folder.c b/folder.c
index 1a095be..70d0033 100644
--- a/folder.c
+++ b/folder.c
@@ -174,7 +174,7 @@ expand_file_name(char *dest, char *src, int expand_mode)
 		    cp = cur_grp;
 		    break;
 		case 'L':
-		    if ((cp = strrchr(cur_grp, '.')))
+		    if ((cur_grp != NULL) && (cp = strrchr(cur_grp, '.')))
 			cp++;
 		    else
 			cp = cur_grp;