#988272 xsane: improve the installation of files in binary packages

Package:
src:xsane
Source:
xsane
Submitter:
Pino Toscano
Date:
2021-05-09 08:33:04 UTC
Severity:
minor
Tags:
#988272#5
Date:
2021-05-09 08:29:54 UTC
From:
To:
Source: xsane
Version: 0.999-11
Severity: minor
Tags: patch

Hi,

currently, the Debian build scripts (rules & debhelper files) ship only
some of the files installed by upstream, and copy manually a couple
more; this results in lack of files producing issues like #963185.

To improve the situation, IMHO the best approach is to ship everything
that upstream installs, and at most do few tweaks like the location of
the documentation, or avoid a full GPL copy. The attached patch does
this job; copying from the changelog:

  * Improve the general installation, also to properly install all the files
    provided by upstream and avoid issues like #963185:
    - ship the complete /usr/share/sane/xsane directory in xsane-common, rather
      than copying one specific file in xsane: this way nothing is missed
    - replace the xsane-gpl.txt file with a symlink to the GPL 2 file in
      /usr/share/common-licenses; xsane shows it in an about dialog
    - add a lintian override for /usr/share/sane/xsane/xsane-eula.txt, as xsane
      shows it in the about eula dialog
    - keep relocating the documentation from /usr/share/sane/xsane/doc to
      /usr/share/doc/xsane-common/html with symlinks for xsane
    - move/install the application icons, and the custom OCR scripts from xsane
      to xsane-common, as they are shared data
    - stop manually installing xsane.xpm, and xsane.png, as the XPM icon is
      already installed by upstream
    - add proper breaks/replaces in xsane-common because of the files moved
      from xsane
    - drop debian/not-installed, as everything from upstream is installed now
    - drop debian/xsane-common.docs, as there are no separate documentation
      files to copy manually
    - drop debian/xsane.dirs, as dh_install creates all the missing directories

As result of shipping exactly what upstream installs, there is also a
reduction in the installed sizes of the xsane, and xsane-common
binaries:
- xsane (on amd64): before is 2346 kb, after is 1630 kb
- xsane-common: before is 5522 kb, after is 4498 kb

Thanks,