#989180 golang-github-smartystreets-assertions-dev: ShouldContain doesn't support slices

#989180#5
Date:
2021-05-27 17:37:52 UTC
From:
To:
Dear Maintainer,

The debian package of github.com/smartystreets/assertions does unvendor
github.com/jacobsa/oglematchers, but the vendored version in the
assertions library did include some improvements. The one I care about
is adding support for slices in ShouldContain:
https://github.com/smartystreets/assertions/commit/6acd0337655254c23e16aae1be5acaa36576faf4#diff-0542b9c1330ae7fd11c64fede96abc85d3c9d5274979545e8c253cbae0ed5940

I'm building a package wich tests fail because it uses this feature.
Maybe this commit could be added as a patch in the debian package
golang-github-jacobsa-oglematchers-dev, it looks pretty safe to add and
should not break any existing code.

Another option will be to remove the vendoring. oglematchers doesn't
seem be maintained, last commit is from 2015. The vendored version in
smartystreets repo seems to be more maintained. To me it looks like the
only package that do depend on is the smartystreets/assertions, maybe
all the golang-github-jacobsa-*-dev packages can be removed.

What do you think? Can I help on anthing there?

Thank you.