#989852 xorg-server-source: Cannot build X from provided source tarball

#989852#5
Date:
2021-06-14 19:10:38 UTC
From:
To:
Hi,

the source tarball of xorg-server shipped via bin:pkg
xorg-server-source in Debian buster is in some broken state. The
reason for this is that quilt patches don't get applied before the
tarball gets created during package build.

Additionally, the xorg-server src:pkg is in some weird patch
management state (which probably is not fixable for buster): it
applies some changes to the upstream code via a .diff.gz file (source
format 1.0) and other patches via quilt. Even more broken the source
tarball becomes because of some changes being applied to xkb/xkb.c via
the diff.gz file, some others via
debian/patches/09_Correct-bounds-checking-in-XkbSetNames.patch.

So, at the moment my 3rd party project depending on the availability
of the xorg-server-source package is not buildable. As a work around,
I provided a fixed 2:1.20.4-1+deb10u3.1 version in a 3rd party repo
outside of Debian.

See the attached .debdiff that fixes the FTBFS issue, but that also
excludes the tarball from itself (#930405) and also applies some
reproducibility fixes.

Please get this change into buster. If help is required, I am happy to
do the upload. Thanks.

The attached fix probably also needs forward porting for the quilt
push/pop -a part. In my changelog (in the .debdiff), I don't close
#930405, so that should be added when uploading.

Thanks!
Mike