In share/Makefile.am, when creating default.vlt it attempts to detect
the availability of the tar --sort= option, but then incorrectly passes
the variable to tar.

It does not appear to affect the sort order on
tests.reproducible-builds.org, but it does appear to cause issues when
testing with reprotest, and so may occur in other situations in the
wild.


The attached patch fixes this by passing it as a make variable rather
than a quoted shell variable.


This patch does not address all reproducibility issues in vlc
(e.g. build paths).


Thanks for maintaining vlc!


live well,
  vagrant

Control: tags 990247 = upstream

Such a patch should be submitted upstream but for a start, it does not look
right to me. Specifically $$tarsort is correct. AFAICT, the problem is that
predicate for the assignment relies on locale-dependent behaviour and thus
fails with non-English languages.

Br,