#991265 keepassxc: URL to the user guide is not the intended one

Package:
keepassxc
Source:
keepassxc
Description:
Cross Platform Password Manager
Submitter:
Date:
2021-08-30 11:09:02 UTC
Severity:
minor
Tags:
#991265#5
Date:
2021-07-19 07:54:26 UTC
From:
To:
Hi,

If I open the User Guide from the Help menu, KeePassXC opens this URL:

  //usr/share/keepassxc/docs/KeePassXC_UserGuide.html

In most browsers this works just fine, but in Tor Browser this results
in a failed attempt to load:

http://usr/share/keepassxc/docs/KeePassXC_UserGuide.html

This comes from:

  customOpenUrl(QString("file:///%1").arg(resources()->dataPath("docs/KeePassXC_UserGuide.html")));

I suppose this makes us pass to customOpenUrl the
file:////usr/share/keepassxc/docs/KeePassXC_UserGuide.html argument
(note the 1 too many leading slash), which apparently QUrl() later
converts to //usr/share/keepassxc/docs/KeePassXC_UserGuide.html.

I suspect replacing file:///%1 with file://%1 in the code I pasted
above would:

 - Fix the problem in Tor Browser, and potentially other browsers.
 - Actually open the URL upstream apparently intended to open.

#991265#12
Date:
2021-08-30 11:04:18 UTC
From:
To:
I _know_ that would fix it :) This was a test of the Debian installer
on release day. The same machine varies with different desktop environments
- for cinnamon and LXDE, it will appear to fail with black screen and will
then come up in default vESA compatible 800x600 mode or so.

For KDE, it might have done the same but the specific firmware warnings
for network hardware - which hadn't got in the way of other installs -
prevented any further progress and it wasn't possible to go to another
virtual terminal and fix the error.

https://wiki.debian.org/Teams/DebianCD/ReleaseTesting/Bullseye_r0 refers
- installs by amacater.

Not really vital but noteworthy.

Andy Cater