#992618 hdparm: /lib/udev/hdparm does not set APM options anymore when resuming from suspend

Package:
hdparm
Source:
hdparm
Description:
tune hard disk parameters for high performance
Submitter:
g1
Date:
2021-08-21 09:39:03 UTC
Severity:
normal
#992618#5
Date:
2021-08-21 09:34:54 UTC
From:
To:
/lib/udev/rules.d/85-hdparm.rules invokes /lib/udev/hdparm when
block devices matching /dev/sdX or /dev/hdX are added.

/lib/udev/hdparm is supposed to extract options relevant to
$DEVNAME and battery-vs-ac status from /etc/hdparm.conf and apply
them using /sbin/hdparm.  According to the changelog, since version
9.58+ds-2 the script singles out APM options and delegates them to
/usr/lib/pm-utils/sleep.d/95hdparm-apm.

However, /usr/lib/pm-utils/sleep.d/95hdparm-apm includes the following fragment:

    # Do nothing when called via /etc/init.d/acpi-support; udev rules take care
    # of setting the initial hdparm policy for us.
    if ([ "$previous" ] && [ "$runlevel" ]) || [ "$runlevel" = S ]; then
	exit 0
    fi

When the condition is met (e.g. acpid handling resume-from-suspend),
APM options are not restored according to /etc/hdparm.conf.  Since udev
rules rely on /lib/udev/hdparm, the comment doesn't apply.

Please revert /lib/udev/hdparm to the previous version, so that it again
does just one thing: apply to device X all options configured for X
in /etc/hdparm.conf.

By the way, every now and then the hdparm package changes in surprising
ways: perhaps including a NEWS.Debian.gz could help.

Best regards,
	g.