#993292 base-files: Dropping VERSION, VERSION_ID and CODENAME from os-release broke systemd-boot

Package:
systemd
Source:
systemd
Description:
system and service manager
Submitter:
Victor Westerhuis
Date:
2022-06-03 21:21:10 UTC
Severity:
normal
Tags:
#993292#5
Date:
2021-08-30 09:33:30 UTC
From:
To:
The upgrade of base-files from 11.1 to 12 broke the use of EFI Unified
Kernel Images[1] with sd-boot. Sd-boot depends on at least one of
VERSION, VERSION_ID, or CODENAME being set[2] by dracut in the embedded
copy of (/etc|/usr/lib)/os-release to detect the file as a valid image.

Would it be possible to set at least one of those?

Regards,


Victor Westerhuis

[1]:
https://systemd.io/BOOT_LOADER_SPECIFICATION/#type-2-efi-unified-kernel-images
[2]:
https://sources.debian.org/src/systemd/247.9-1/src/boot/efi/boot.c/#L1985

#993292#10
Date:
2021-08-30 12:26:49 UTC
From:
To:
No. Relaying on VERSION, VERSION_ID, or CODENAME is a bad idea.

Packages uploaded for unstable right now are intented to work in a
bookworm environment (when stable), so there should be no need to use "cases".

If absolutely necessary, sd-boot could assume that codename is "bullseye"
when undefined, but this will only work until there is a behaviour
change between bullseye and bookworm in any of the tools on which
sd-boot depends. This is why Depends were created.

In either case, if you need to act differently according to specific
things that alter the desired behaviour of sd-boot, it will be a lot
better to check for those things specifically, not the Debian version.

Please reassign.

#993292#17
Date:
2021-09-05 12:17:59 UTC
From:
To:
reassign 993292 systemd
thanks

Hi. I asked this bug to be reassigned here:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=993292#10

Now I see that you added an "affects", so I have to repeat: This is
*not* a bug in base-files. The standard says

VERSION
  This field is optional.
VERSION_ID
  This field is optional.
VERSION_CODENAME
  This field is optional and may not be implemented on all systems.

Source: https://www.freedesktop.org/software/systemd/man/os-release.html

Therefore any program unconditionally assuming that any of those exist
is buggy and should be fixed.

Thanks.

#993292#30
Date:
2022-06-03 21:08:27 UTC
From:
To:
Hello,

Bug #993292 in systemd reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/systemd-team/systemd/-/commit/ce8a2c093bb88e7f26b67c9a0f701b57f77c2e83
------------------------------------------------------------------------
Do not require a valid version when parsing sd-boot loader entries

Closes: #993292
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/993292

#993292#35
Date:
2022-06-03 21:19:45 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
systemd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 993292@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Biebl <biebl@debian.org> (supplier of updated systemd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Fri, 03 Jun 2022 19:37:06 +0200
Source: systemd
Architecture: source
Version: 251.2-1
Distribution: unstable
Urgency: medium
Maintainer: Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>
Changed-By: Michael Biebl <biebl@debian.org>
Closes: 993292 1009032 1012155
Changes:
 systemd (251.2-1) unstable; urgency=medium
 .
   [ Michael Biebl ]
   * New upstream version 251.2
     - logind: do not print wall messages to local pseudoterminals
       (Closes: #1012155)
   * Rebase patches
   * Fix parsing of command line options in fsckd (Closes: #1009032)
   * Do not require a valid version when parsing sd-boot loader entries
     (Closes: #993292)
   * Add dpkg file trigger for systemd-binfmt to update binfmt registrations
   * Use a single NEWS file shipped in the main systemd package
 .
   [ Luca Boccassi ]
   * autopkgtest: add cryptsetup-initramfs for upstream suite.
     Needed for https://github.com/systemd/systemd/pull/23517
Checksums-Sha1:
 89a774668cf0cbfca412935bb0337408e9448052 5721 systemd_251.2-1.dsc
 9b2cb81138ce2a347ecbeebb54124a23a78264a4 11434645 systemd_251.2.orig.tar.gz
 dcff816f0cb6d77091c56468143af90efe4d1911 163340 systemd_251.2-1.debian.tar.xz
 ab9f43c020873fcac0e29c3df4c0e10b310e0e9f 10450 systemd_251.2-1_source.buildinfo
Checksums-Sha256:
 e0f2f80df433335d72f9260b860d3312ff7bdbdfd628e292170ab9a905c1825b 5721 systemd_251.2-1.dsc
 5b371e824fe3e3128f2338b8db8cd37171f8e249eea88077eea468f73d833545 11434645 systemd_251.2.orig.tar.gz
 2723048c97d4b1e013279c620a13b1f1503cf4998bf20eaa2b9ef89781220510 163340 systemd_251.2-1.debian.tar.xz
 9eb376eb8b87e5c3f80992e4bf9ed30a3a588adf30e0a0a5548fabbb7cb7ddca 10450 systemd_251.2-1_source.buildinfo
Files:
 09a1fa2da1c3cddff003e4c9cc1ba3bc 5721 admin optional systemd_251.2-1.dsc
 b5cc5a46e80ab3aa25f8e15f763b05fa 11434645 admin optional systemd_251.2.orig.tar.gz
 46aedbe4bb32ecd0481cbcfbefcaba67 163340 admin optional systemd_251.2-1.debian.tar.xz
 8bfecd17b3b05aacc4668a6932c4cdf3 10450 admin optional systemd_251.2-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEECbOsLssWnJBDRcxUauHfDWCPItwFAmKaeBcACgkQauHfDWCP
ItzXvA/+NuccHF9BaEM+z2+77noh3h+8j/xkI927r6ZTrLqZGlK2Itwvx+CM+di6
GRER15lp81+8HRUBF7gPDnUj9W6U3RcaeKg20DFygXDI7eCP0RjfzRz4JlhselvT
s4jjITDjaGAb6fZBnFSXiNHWFOjot7j+OrV0Bhi4H3qQNRrvneuSFjnlxCCmcPiQ
UZ7CZCdPYSVlnCitH5HbQQwvwls8neGCPOUqxO2qW1AhMl9eG6kaz7ahZzVwzYEh
rzVW1n8v96NaORjYWHXaWHYDGlfn2TdDrCX6rJKaUI78JCqX2br7MFbAwL+mgXpa
O1APrKJBi6PZK0GoDFJT1NsMk3IMV37Jdbi4Do193X4RayWrP+puTit+ecKhZRPu
2x8bZ3q/0iNoBKld8ZtMbJ11lfQd6Zv10eJQQnJkm6BiLi99CRWK3/1uKtP4j+HA
0ZMUAGuJDr9uG9eXCqQBHipi4PO4/+wjlEe8GzyPr1S9WIcfFxuoJQ+GuoN3tvDs
uyf2SbcdHT9O04vVbhv58NMTJk+gw43grfAs8qJ/ZqL3oOkJ1OYjmotCKh5NqGiw
5KhJZzVwTF8HOyStpSlImzUmHHIE3yw9JHeLV/CsJUqWZipi73+R77hpCr0L0MIw
y0huVcZfQTAefojkFoXvPyC5x8Z8O+6T13ev5iieZ4RR2nRUiao=
=CU0B
-----END PGP SIGNATURE-----