#993521 buildbot-worker: Setting WORKER_OPTIONS to any non-empty value doesn't work

Package:
buildbot-worker
Source:
buildbot
Submitter:
Vadim Zeitlin
Date:
2021-09-02 14:12:02 UTC
Severity:
normal
#993521#5
Date:
2021-09-02 13:56:18 UTC
From:
To:
Dear Maintainer,

Setting WORKER_OPTIONS in /etc/default/buildbot-worker to e.g. "--verbose"
doesn't work because its value is used in a wrong place in the init.d
script: it does

	"$WORKER_RUNNER $op ${WORKER_OPTIONS[$mi]} ${WORKER_BASEDIR[$mi]}

when the correct syntax would be

	"$WORKER_RUNNER ${WORKER_OPTIONS[$mi]} $op ${WORKER_BASEDIR[$mi]}

i.e. the options must come _before_ the operation for buildbot-worker, not
after it.