#994703 nodejs: please documents deps or avoid it

Package:
nodejs
Source:
nodejs
Description:
evented I/O for V8 javascript - runtime executable
Submitter:
"Bastien Roucariès"
Date:
2021-09-20 04:18:03 UTC
Severity:
normal
#994703#5
Date:
2021-09-19 16:50:53 UTC
From:
To:
Dear Maintainer,

README.source should document the deps directory.

It will be better to remove some libs from deps. Why libz is needed for node ?
Could we push this plugin stuff to libz and so on.

Acorn embdeded should be fixed by recent version.

openssl one is worry some...

Bastien

#994703#10
Date:
2021-09-19 19:27:18 UTC
From:
To:
Le dim. 19 sept. 2021 à 18:54, Bastien Roucariès <
roucaries.bastien@gmail.com> a écrit :

Hi,

What's in ./deps/ is mostly not used for building node.
It's pretty much obvious if you look at ./debian/rules configure flags.

I believe it is not common practice to remove unused files, as long as it's
okay with DFSG.
That's why
zlib, openssl, nghttp2, http-parser, uv, c-ares, brotli
are kept around in ./deps/ directory.

This is actually useful, it makes debugging against "upstream-like" builds
easier.

Jérémy

#994703#15
Date:
2021-09-19 20:22:21 UTC
From:
To:
Le dim. 19 sept. 2021 à 19:33, Jérémy Lal <kapouer@melix.org> a écrit :

Yes but README.Source is in this case good
Yes also

Yes but in order to be less worried about something in this huge code
base use these files, I will really prefer to move the deps dir before
configure or removing the -r bit in order to avoid something strange

I was hit ten years ago by some leaking hardcoded path on a project I
compiled, and I really prefer to be paraonoiac on this side

Bastien

#994703#20
Date:
2021-09-19 20:58:56 UTC
From:
To:
Le dim. 19 sept. 2021 à 22:27, Bastien ROUCARIES <
roucaries.bastien@gmail.com> a écrit :

Yes, why not. Better safe than sorry.

Jérémy