#996816 hw-detect: check-missing-firmware generates modprobe errors

Package:
hw-detect
Source:
hw-detect
Submitter:
Daniel Lewart
Date:
2021-10-19 08:09:03 UTC
Severity:
minor
Tags:
#996816#5
Date:
2021-10-19 07:31:00 UTC
From:
To:
Debian Install System Team,

Revisiting "#973733 - RTW88_8821ce module fails to find firmware during
install and must be reloaded":
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=973733#61
the Bullseye installation experience!

I have created a variation on that variation, with some improvements:
  1) Sit out the first modprobe dance to avoid generating faux-pas errors.
     This assumes that every driver has a corresponding module.
  2) Rename variables in the remove/reload section for improved clarity:
     module -> driver; driver -> drv_path; actual_module -> module
  3) Remove unused get_module function
  4) Fix UUOC
  5) Change "! -n" to "-z"
  6) Fix comment typo

Tested patch is attached.

Thank you!
Daniel Lewart
Urbana, Illinois