Hi Thunderbird devs--

librnp has made it into debian testing (0.15.2-6 as of right now).

I think thunderbird is currently building from an embedded copy of
librnp.

RNP Upstream has been collaborating nicely by fixing issues i've raised
with them that highlight concerns in debian.

It would be better if we could avoid the embedded code copy by building
thunderbird against the debian librnp-dev package, and depending on
librnp0.

Thanks for maintaining thunderbird in debian!

Regards,

Hi Daniel,

Am 08.11.21 um 19:51 schrieb Daniel Kahn Gillmor:

I would happily switch using a external (system) library librnp-dev
which we could use while package build.

But I think it's a bit more complicated currently, a quick look into the
source shows me that the upstream build system doesn't support the usage
of an external librnp-dev package right now.
This needs to get addressed upstream I think so we can build against the
system library.

If you want to jump in here then feel to do so, I'm short on time for
doing something like this in the near future.

Thanks, I've opened https://bugzilla.mozilla.org/show_bug.cgi?id=1740320
so that upstream is aware of the issue.

I've just uploaded rnp 0.16.0 into debian unstable.  According to
https://bugzilla.mozilla.org/show_bug.cgi?id=1732809 the main
development line of thunderbird now has a --with-system-rnp flag (but
the 91esr series doesn't have it.

So when new versions of thunderbird get built in debian (in experimental
first, maybe?) please try to use --with-system-rnp.  If you run into any
reason why building against the system rnp isn't working, please don't
hesitate to file bug reports against rnp and we'll sort them out.

thanks for all your work on thunderbird in debian!

Hello Daniel,

Am Sat, Mar 26, 2022 at 04:06:46PM -0400 schrieb Daniel Kahn Gillmor:

after again months of waiting for some typical build tools and a lot of
try and errors attempts I'm now able to build the current beta version
of Thunderbird (102.0~b4) together with the system package of
librnp-dev.

The downside is that this requires currently the usage of the internal
version of botan, bz2 and jsonc.
I've no kowledge if upstream has plans to reenable the usage of system
packages for these tools, maybe it's also just a misconfiguration of the
buildsystem.

Hopefully I can upload a first beta version of Thunderbird zu
experimental soon.

Regards
Carsten

Hi Carsten--

that's great news!  thanks for doing this.

Ugh, that doesn't sound so reasonable.  I'd expect those libraries to be
internal to librnp, and not directly exposed to the rest of thunderbird.
so they shouldn't be related to the build process at all, afaict.

Have you reported this upstream at all?  do you have examples of the
build failures that happen when you use the system librnp that we could
work through and post where upstream can see them?

Hi Daniel,

Am 15.06.22 um 17:12 schrieb Daniel Kahn Gillmor:

uploaded to experimental just right now.

Preparing the current version did make a lot of headaches. :-)
So far I've experienced we need to use the option --enable-av1 now to
get a recent Thunderbird, otherwise the build failed with an error
messages that make not really sense to me.

Building TB with AV1 support isn't something what I think is needed to
have. :-) But well, the build configuration isn't something that is
getting less complex over time.
No, I haven't reported any issue upstream yet, I wanted first to have a
basic working Thunderbird package for the current Beta versions.
Unfortunately I often needed to wait in the past on the most bleeding
edge Rust and Cargo stuff due the version dependencies. And now we are
getting closer to the next ESR version of Thunderbird, a broader user
base that can try out these version(s) is more helpful for Debian and to
me as we can mostly work around some upstream issues.

I see currently two main things we need to bring to upstream issue tracker.

1) Why we can't set --disable-av1 as before and the configure script is
    ending with an exit code of 1.

2) What is needed to modify in the upstream configure script voodoo so
    its possible to use the configure options

We believe that the bug you reported is fixed in the latest version of
thunderbird, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 998848@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Carsten Schoenert <c.schoenert@t-online.de> (supplier of updated thunderbird package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Wed, 15 Jun 2022 16:47:29 +0200
Source: thunderbird
Architecture: source
Version: 1:102.0~b4-1
Distribution: experimental
Urgency: medium
Maintainer: Carsten Schoenert <c.schoenert@t-online.de>
Changed-By: Carsten Schoenert <c.schoenert@t-online.de>
Closes: 998848
Changes:
 thunderbird (1:102.0~b4-1) experimental; urgency=medium
 .
   * [8f34a01] d/source.filter: Small updates to filtering list
   * [e1d4c7c] New upstream version 102.0~b4
   * [c97416b] Rebuild patch-queue from patch queue branch
     Removed patch (needs update):
     fixes/Bug-1494436-Unset-MOZ_APP_LAUNCHER-for-external-MIME-hand.patch
     Removed patch (fixed upstream):
     porting-armhf/Don-t-use-LLVM-internal-assembler-on-armhf.patch
   * [68712eb] d/mozconfig.default: Disable wasm sandboxing
   * [a1df764] d/mozconfig.default: Remove openpgp option
     Supporting OpenPGP functionality is now set on by default.
   * [607c321] d/mozconfig.default: Add/Update some configure options
   * [efc728e] d/rules: Add new needed variable MOZBUILD_STATE_PATH
   * [7b0d743] d/rules: Ensure python is used from the environment
   * [26053f1] Build against system librnp library
     Unfortunately using librnp-dev requires the usage of the internal
     versions of botan, bz2 and jsonc.
     (Closes: #998848)
   * [5e904d8] d/control: Bump various build dependencies
   * [94ee0da] d/thunderbird.docs: Update content to install
   * [477f949] d/control: Increase Standards-Version to 4.6.1
     No further changes needed.
Checksums-Sha1:
 06f0f980a48cdb5ea52105fa76c29274b817d25e 8503 thunderbird_102.0~b4-1.dsc
 5126ebf00d7397ea0755ce01cf92d01d5f8e18c3 12161192 thunderbird_102.0~b4.orig-thunderbird-l10n.tar.xz
 b02bd803487f62a5a40acee291d47835af4cd59f 526951156 thunderbird_102.0~b4.orig.tar.xz
 86a7aba34753e239efd878c89daf0c17802a594e 542456 thunderbird_102.0~b4-1.debian.tar.xz
 1c70f09bfca01a0dd2afe1e6115b2d30e662143e 37156 thunderbird_102.0~b4-1_amd64.buildinfo
Checksums-Sha256:
 85ee28081e05537594c9b811f1a84914c7291e9b8278c171076bcbc8eda9c7af 8503 thunderbird_102.0~b4-1.dsc
 3ef6e75e5e7c0067f85afe6edfc1e210baae4a7b5e099c22558a78152266253e 12161192 thunderbird_102.0~b4.orig-thunderbird-l10n.tar.xz
 13e9287a954ad172b45379898985c5bfe86e2803f646554c27eba071b64940f5 526951156 thunderbird_102.0~b4.orig.tar.xz
 7b0320fd1206ad9846c03f73e79b06bd6cf65f0127c74a53ba376cd4a5051db9 542456 thunderbird_102.0~b4-1.debian.tar.xz
 480b90750086e3a243f7cf34aaa6761d450b82807a5d3a1111ef5544563874af 37156 thunderbird_102.0~b4-1_amd64.buildinfo
Files:
 f70008f443190881b01739c3f3ef93ce 8503 mail optional thunderbird_102.0~b4-1.dsc
 d956464c5ee99be2f5c4ce963bdbeb27 12161192 mail optional thunderbird_102.0~b4.orig-thunderbird-l10n.tar.xz
 ae0e33705b92a40da5cbeadb344e5608 526951156 mail optional thunderbird_102.0~b4.orig.tar.xz
 3b3ecc2d1fb9dcf243f2c9a7a87a9a30 542456 mail optional thunderbird_102.0~b4-1.debian.tar.xz
 c07bd9e1adc9935f4e36bfaa2bc483db 37156 mail optional thunderbird_102.0~b4-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEtw38bxNP7PwBHmKqgwFgFCUdHbAFAmKp/VgACgkQgwFgFCUd
HbC7gg//QOPYMqXafs2pnAEOd/G/vptFO1Gy9ca086lNNDoIlwVFBG5fTH/e38zL
9U/9Qx5DF7vRALC7v5dNPlAEj69XaOas6ThU82ZnRmTRqxDlW8GzIeK2zqfI+xFt
Kxjh1Jg8yu1Vp6NpTR6RmprLdhQN4gLYcRAzZutKuBBXIXI2nAJXXkWU7Qfck+Yu
cSTHQP8BwwgvS7swtTiMtzJ0+yEHhZXEPiaXCVU7m3O0GxkmOrHHdkuL5tYB0upb
AhbLsYZH9+7cxk2DmQVbw/uCJuax77Hy4pQ0GqY2KE1OOhYxCzoLRuRVa9S0l6Ho
ek8vDZlogFAm3cX2oZnSRk0PfZlgnpVWKTPE7LIyw6YZJnvLqHnKWvH7DJ6sYNOu
4Y/U+50NHEK/WrQxaEFG7Nq+cjlA2faK6LX+hNv+qKhCzxr7QJd330ekJUEC5KTJ
I4MCZ6m8IklxG1lK7Plmn9FlCLa40Ef26htiS3FV0u/MnB2zcJ9lpUjgwq3B+db9
LIKrx9zsPLRcOtOunjYbHBEFjJRJcUlCCO/S8J2mHnOGQZ4jzYleDAlalt5UnWp6
2esoZIcmG/E1kXCDedSN9p7Z5h5hjUkmy3VVqrSk8IbtUe1M9gBZDQzn3r7i+m9n
U62pgVxWros6hu4JJZEKJDbdlG2X+QhoG9nuYBdpH//68GfdfRU=
=DDKT
-----END PGP SIGNATURE-----

Is it possible that these three flags aren't relevant any longer
*because* we're using the system rnp?

in comm/third_party/openpgp.configure i see the tests for those options
bracketed within a block that begins:

-----
with only_when(in_tree_librnp):
-----

And i don't see those options anywhere else in the codebase.

It would make sense if those options shouldn't be supplied at all any
longer when we're using the system rnp, and i'd expect that the updated
thunderbird wouldn't acquire any new dependencies from omitting those
changes.

I'd guess that you can probably also remove the build-deps on:

libbotan-2-dev
libbz2-dev
libjson-c-dev

And the build should complete without an error, but i haven't tested it
myself.

Thank you very much for working on this, Carsten!

Hi Daniel,

Am 15.06.22 um 19:58 schrieb Daniel Kahn Gillmor:

thanks for digging into this, I wasn't in the mood to go down that road
until now. :-)
Was happy to get a successful build after months.

If your analysis is correct than we don't want these build dependencies
any more, right. I've simply forgotten to at least comment these out for
now. The next beta is around the corner to get clear on this. :-)

Will do this the next time I import a new upstream version, but my guess
is we can simply remove them now.

Sounds like a good plan to me.  Thanks again for doing this work,
Carsten.  I'm running thunderbird from experimental right now, and I
haven't noticed any new problems with it so far.