#999887 dcmtk FTCBFS: uses TRY_RUN check for signedness of char

Package:
src:dcmtk
Source:
dcmtk
Submitter:
Helmut Grohne
Date:
2022-06-20 06:57:08 UTC
Severity:
normal
Tags:
#999887#5
Date:
2021-11-17 18:40:07 UTC
From:
To:
dcmtk fails to cross build from source, because it uses a TRY_RUN check
to determine whether char is signed. Such a check does not have to run
code (which does not work during cross compilation), but can be written
as a compile only test. Please consider applying the attached patch to
fix this instance of TRY_RUN. There are more TRY_RUN to be fixed to make
dcmtk cross buildable though. So please consider applying the attached
patch as an incremental step.

Helmut
#999887#12
Date:
2021-11-19 13:22:05 UTC
From:
To:
Control: tags -1 - patch
Control: tags -1 fixed-upstream
[...]

Turns out this has been integrated directly upstream:

* http://git.dcmtk.org/?p=dcmtk.git;a=commitdiff;h=99849fffe1771096a28e6ca6cae60017b8bfa72b
#999887#21
Date:
2021-11-19 15:24:11 UTC
From:
To:
Hi Mathieu,

I think the upstream solution is not as good as mine, because it
requires you the user to provide the check result. Other than that, the
upstream solution is more complete and covers more TRY_RUN. Maybe you
could propose my patch upstream as a further improvement?

With the upstream patch, you'll have to adapt the debian packaging and
pass the relevant flags given in the commit message. Doing so would be a
continuous maintenance effort (both in terms of added checks and in
terms of added architectures). For that reason, I recommend pursuing my
approach as a means to reduce the long-term maintenance cost.

Given that the upstream fix is incomplete from a debian pov (you also
need to update debian/rules), I'm removing the fixed-upstream tag.

Helmut
#999887#35
Date:
2022-06-20 06:54:11 UTC
From:
To:
#999887#42
Date:
2022-06-20 06:54:11 UTC
From:
To: